[Bug 199929] [NEW PORT] math/cryptominisat

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199929

--- Comment #1 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 156338
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=156338
Patch with new port

$ portlint -AC
WARN: /usr/ports/math/cryptominisat/pkg-plist: [8]: installing shared
libraries, please define USE_LDCONFIG as appropriate
FATAL: /usr/ports/math/cryptominisat/pkg-plist: the last line has to be
terminated by \n.

>+++ math/cryptominisat/Makefile	2015-05-02 22:20:57.733228258 +0300
[...]
>+.include <bsd.port.options.mk>
>+
>+.if ${PORT_OPTIONS:MPYTHON}

New ports should use option helpers if possible.

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html#options-helpers

>+USES+=		python:build

USES=python with no version specified is for ports that support both
python2 and python3. CMakeLists.txt seems to disagree:

  find_package (PythonInterp 2.7)
  find_package (PythonLibs 2.7)

>+PLIST_SUB+=	EGGFILE=pycryptosat-${PORTVERSION}-py${PYTHON_VER}.egg-info
>+.else
>+CMAKE_ARGS+=	-DPYTHON_EXECUTABLE=0
>+.endif

>++++ python/CMakeLists.txt
>+@@ -12,7 +12,7 @@ add_custom_command(OUTPUT ${OUTPUT}/time
>+ 
>+ add_custom_target(pytarget ALL DEPENDS ${OUTPUT}/timestamp)
>+ 
>+-install(CODE "execute_process(COMMAND ${PYTHON_EXECUTABLE} ${SETUP_PY} install --record files.txt)")
>++install(CODE "execute_process(COMMAND ${PYTHON_EXECUTABLE} ${SETUP_PY} install -c -O1 --prefix=${CMAKE_INSTALL_PREFIX} --root=${FREEBSD_STAGEDIR} --record files.txt)")

Why not create a separate USE_PYTHON=distutils port that depends on this one?

>+++ math/cryptominisat/pkg-plist	2015-05-02 16:26:25.333693829 +0300
>@@ -0,0 +1,10 @@
[...]
>+lib/libcryptominisat4.so

Maybe set SOVERSION, so the library path can be cached by ldconfig(8)
and used not only via RPATH.

-- 
You are receiving this mail because:
You are the assignee for the bug.