[Bug 198217] games/minecraft-server: avoid java-args.txt if DAEMON [PATCH]

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198217

Jonathan Price <freebsd at jonathanprice.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #154091|                            |maintainer-approval+
              Flags|                            |

--- Comment #6 from Jonathan Price <freebsd at jonathanprice.org> ---
Created attachment 154091
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=154091&action=edit
Patch demonstrating radio options

I apologise if I hadn't expressed my point clearly enough earlier. I have now
produced a patch to demonstrate my thoughts.

This patch removes the DAEMON option, and instead offers two radio options,
STANDALONE and DAEMON.

If you select STANDALONE, it installs java-args.txt and
/usr/local/bin/minecraft-server.

If you select DAEMON, it installs /usr/local/etc/rc.d/minecraft

The issue I was having before, was that the DAEMON option was an additional
option, rather than selecting daemon OR standalone, so technically speaking the
DAEMON option should have given you the choice to run it as a daemon AND
standalone, as you hadn't specified not to install the standalone files.
Therefore, it would have caused confusing results for some users who didn't
expect adding an option to remove files from the base install.

If you have time, please give this patch a quick test and see if you can
understand what I'm trying to say.

I thank you for your continued time on this matter.

-- 
You are receiving this mail because:
You are the assignee for the bug.