[Bug 198379] net/liboping: Update to 1.8.0, Fix MASTER_SITES, WWW, Request MAINTAINER'ship

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198379

--- Comment #2 from Kubilay Kocak <koobs at FreeBSD.org> ---
Thanks Chris,

On initial review:

- COMMENT: Match upstream "tagline, comment" as close as possible. See:

http://noping.cc/

COMMENT=C library to generate ICMP echo requests

https://github.com/octo/liboping

COMMENT=Protocol independent ANSI-C ping library and command line utility

tldr; The original/previous value of COMMENT looks fine.

- Always strip in post-install:
- You're using INSTALL_TARGET=install-strip, but manual STRIP_CMD is still
used? Use one or the other, ideally the former if it works.

- You mention ncurses as an option, but there it doesn't look OPTION'al or
conditional.
- Try to use LIBS to add -lncurses instead of LDFLAGS
- Dont hardcode -lncurses, use the variables provided by Mk/Uses/ncurses.mk

- Group and sort USE_*/USES sections

- When you update PORTVERSION, PORTREVISION is/should be reset (so remove it)

-- 
You are receiving this mail because:
You are the assignee for the bug.