[Bug 201781] [patch] sysutils/screen parallel build can fail

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201781

            Bug ID: 201781
           Summary: [patch] sysutils/screen parallel build can fail
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: cy at FreeBSD.org
          Reporter: truckman at FreeBSD.org
          Assignee: cy at FreeBSD.org
             Flags: maintainer-feedback?(cy at FreeBSD.org)
          Keywords: patch

Created attachment 159106
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=159106&action=edit
patch to add missing dependencies to unbreak parallel build

I experienced this build failure on FreeBSD 11.0-CURRENT when running a
parallel build under poudriere:



=======================<phase: build          >============================
===>  Building for screen-4.3.1_1
gmake[1]: Entering directory
'/wrkdirs/usr/ports/sysutils/screen/work/screen-4.3.1'
CPP="cpp -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"'" srcdir=. sh
./osdef.sh
AWK=/usr/bin/awk CC="cc -O2 -pipe  -DCOLORS256 -fstack-protector
-fno-strict-aliasing" srcdir=. sh ./comm.sh
AWK=/usr/bin/awk srcdir=. sh ./term.sh
sh ./tty.sh tty.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\""`git describe --always 2>/dev/null`"\" \
     -O2 -pipe  -DCOLORS256 -fstack-protector -fno-strict-aliasing putenv.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\""`git describe --always 2>/dev/null`"\" \
     -O2 -pipe  -DCOLORS256 -fstack-protector -fno-strict-aliasing
list_generic.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\""`git describe --always 2>/dev/null`"\" \
     -O2 -pipe  -DCOLORS256 -fstack-protector -fno-strict-aliasing
list_display.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\""`git describe --always 2>/dev/null`"\" \
     -O2 -pipe  -DCOLORS256 -fstack-protector -fno-strict-aliasing
list_window.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\""`git describe --always 2>/dev/null`"\" \
     -O2 -pipe  -DCOLORS256 -fstack-protector -fno-strict-aliasing term.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\""`git describe --always 2>/dev/null`"\" \
     -O2 -pipe  -DCOLORS256 -fstack-protector -fno-strict-aliasing kmapdef.c
list_window.c:121:12: error: use of undeclared identifier 'RC_KILL'
  act.nr = RC_KILL;
           ^
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\""`git describe --always 2>/dev/null`"\" \
     -O2 -pipe  -DCOLORS256 -fstack-protector -fno-strict-aliasing screen.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\""`git describe --always 2>/dev/null`"\" \
     -O2 -pipe  -DCOLORS256 -fstack-protector -fno-strict-aliasing ansi.c
1 error generated.
Makefile:82: recipe for target 'list_window.o' failed
gmake[1]: *** [list_window.o] Error 1
gmake[1]: *** Waiting for unfinished jobs....
gmake[1]: Leaving directory
'/wrkdirs/usr/ports/sysutils/screen/work/screen-4.3.1'
===> Compilation failed unexpectedly.


The problem is that the RC_KILL symbol is defined in comm.h, but this is a
generated header that is not listed as a dependency of list_window.o in the
Makefile.  When doing a parallel build it is possible that list_window.c may
get compiled before comm.h is fully baked.

The attached patch adds this and other missing dependencies to the Makefile.

-- 
You are receiving this mail because:
You are the assignee for the bug.