[Bug 200017] print/gimp-gutenprint: Poudriere build fails with an orphaned item

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200017

Christoph Moench-Tegeder <cmt at burggraben.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #157090|0                           |1
        is obsolete|                            |

--- Comment #4 from Christoph Moench-Tegeder <cmt at burggraben.net> ---
Created attachment 159092
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=159092&action=edit
revised patch

Fixed:
- WARNING: unrecognized options: --with-gimp
  yes, that's gone
- I used INSTALL_TARGET=install-strip to get rid of the "not stripped"
warnings.

What's left:
- WARN: Makefile: [99]: use ${VARIABLE}, instead of $(VARIABLE).
  this this seems to be a false-positive on the content of that REINPLACE,
there's "$(pkglibdir)" in there which has to stay (it's not a make variable,
it's the original file's content).
- WARN: Makefile: [50]: You may remove pkg-plist if you use PLIST_FILES and/or
PLIST_DIRS.
  the PLIST_FILES are used for a sub-port, and the pkg-plist is used for this
(the -base) port
- WARN: Makefile: Consider adding support for a NLS knob to conditionally
disable gettext support.
  not now. is that still a thing?
- WARN: Makefile: unless this is a master port, PORTNAME has to be set by "=",
not by "?=".
  it's a master port.
- and two warning about patches not being in makepatch format - for now, I'll
leave them as-is, and will fix them when their content changes.

I have no printer suitable for testing this, so... good luck?

-- 
You are receiving this mail because:
You are the assignee for the bug.