[Bug 201703] [PATCH] textproc/p5-EBook-Tools: update to 0.5.4, fix tidy usage

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201703

--- Comment #1 from Jason Unovitch <jason.unovitch at gmail.com> ---
Hello maintainer of p5-Ebook-Tools,

I've been looking at updating textproc/p5-Ebook-Tools based on efforts in bug
200631.  This is the only port left that is currently referencing the old
www/tidy port that has a security issue that still needs to be fixed.  If we
opt to remove it we'll need to adjust this port to use tidy5.

What I found is the current p5-Ebook-Tools is broken with regards to tidy
usage.  It tried to use 'tidy' when 'tidy4' is the installed binary.  So while
here to make sure tidy5 works, I updated the port.

== Runtime testing ==
== 0.4.9_2 ==

# ebook tidyxml /usr/ports/security/vuxml/vuln.xml 
Can't exec "tidy": No such file or directory at
/usr/local/lib/perl5/site_perl/EBook/Tools.pm line 6812.
Tidy did something unexpected (return value=-1).  Check all output. at
/usr/local/bin/ebook line 1383.

Once I fix line 92 of /usr/local/bin/ebook to fall back to tidy4, it works.  I
ran these two commands to get a baseline of what output to expect before.

# ebook tidyxml /usr/ports/security/vuxml/vuln.xml
# ebook tidyxhtml /usr/local/share/doc/bash/bash.htmldoc/bash/bash.html

== 0.5.4 ==

After the 0.5.4 update, I checked the same two commands.  The different
versions of tidy produce different white space padding but aside from that the
output appears to be the same.  I visually inspected the resulting HTML with
Firefox and it looks fine in both the old and new.

# ebook tidyxml /usr/ports/security/vuxml/vuln.xml
# ebook tidyxhtml /usr/local/share/doc/bash/bash.htmldoc/bash/bash.html

-- 
You are receiving this mail because:
You are the assignee for the bug.