[Bug 201514] net-mgmt/collectd5 - upstream released version 5.5.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201514

Jason Unovitch <jason.unovitch at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason.unovitch at gmail.com
 Attachment #158964|                            |maintainer-approval?(ports@
              Flags|                            |bsdserwis.com)

--- Comment #19 from Jason Unovitch <jason.unovitch at gmail.com> ---
Created attachment 158964
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=158964&action=edit
collectd5-5.5.0.patch

Nice work on this!  I see there were a handful of QA issues shown with portlint
so I've addressed them with the attached revision of your cumulative patch.

WARN: Makefile: [513]: BROKEN messages should not be quoted.
WARN: Makefile: [166]: IGNORE messages should begin with a lowercase letter and
end without a period.
WARN: Makefile: no ftp/http mirror in MASTER_SITES for users behind a proxy.
WARN: /usr/ports/net-mgmt/collectd5/files/patch-src__daemon__collectd.h: patch
was not generated using ``make makepatch''.  It is recommended to use ``make
makepatch'' to ensure proper patch format.
WARN: /usr/ports/net-mgmt/collectd5/files/patch-src__daemon__Makefile.am: patch
was not generated using ``make makepatch''.  It is recommended to use ``make
makepatch'' to ensure proper patch format.
WARN: /usr/ports/net-mgmt/collectd5/files/patch-src__dns.c: patch was not
generated using ``make makepatch''.  It is recommended to use ``make
makepatch'' to ensure proper patch format.
WARN: /usr/ports/net-mgmt/collectd5/files/patch-src__Makefile.am: patch was not
generated using ``make makepatch''.  It is recommended to use ``make
makepatch'' to ensure proper patch format.
WARN: /usr/ports/net-mgmt/collectd5/files/patch-src__modbus.c: patch was not
generated using ``make makepatch''.  It is recommended to use ``make
makepatch'' to ensure proper patch format.
WARN: /usr/ports/net-mgmt/collectd5/files/patch-version-gen.sh: patch was not
generated using ``make makepatch''.  It is recommended to use ``make
makepatch'' to ensure proper patch format.


The patch I've attached addresses these.  The patches were all standardized
with the 'make makepatch' header to silence the noise from those warnings.  The
BROKEN message was an easy fix.  The no ftp/http mirror for proxy users was
solved with using the https link first followed by the http link.  The only
remaining message is unfixable since CGI is a proper acronym and we can't
change that.

WARN: Makefile: [167]: IGNORE messages should begin with a lowercase letter and 
end without a period.


Lastly, being an SVN patch, this should cleanly apply and handle the file
removals and additions.  I had to run the commands below so this wraps it up
with the SVN patch:
svnlite rm --force patch-src-curl_xml.c patch-src__collectd.c
patch-src__collectd.h patch-src__disk.c patch-src__users.c patch-src_modbus.c
svnlite add patch-src__daemon__Makefile.am patch-src__daemon__collectd.h
patch-src__modbus.c

-- 
You are receiving this mail because:
You are the assignee for the bug.