[Bug 201193] Mk/bsd.php.mk setting incorrect PHP_EXT_DIR

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201193

Peter Wemm <peter at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |peter at FreeBSD.org

--- Comment #5 from Peter Wemm <peter at FreeBSD.org> ---
IMHO, the code that causes the module build to examine apache's threading state
is entirely inappropriate as a heuristic to guess whether php was built with
ZTS or not.

I mean, seriously:
HTTPD?=         ${LOCALBASE}/sbin/httpd
.if exists(${HTTPD})
APACHE_THR!=    ${HTTPD} -V | ${GREP} threaded
.       if ${APACHE_THR:Myes}
PHP_EXT_DIR:=   ${PHP_EXT_DIR}-zts
.       endif
.elif defined(APACHE_PORT) && (${APACHE_PORT:M*worker*} != "" ||
${APACHE_PORT:M*event*} != "")
PHP_EXT_DIR:=   ${PHP_EXT_DIR}-zts
.elif defined(WITH_MPM) && (${WITH_MPM} == "worker" || ${WITH_MPM} == "event")
PHP_EXT_DIR:=   ${PHP_EXT_DIR}-zts
.endif

The only thing it doesn't seem to actually check is whether ZTS is enabled or
not.

-- 
You are receiving this mail because:
You are on the CC list for the bug.