[Bug 196248] net/libsrtp: Upgrade to latest from GitHub

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196248

--- Comment #8 from Tijl Coosemans <tijl at FreeBSD.org> ---
(In reply to Mikhail T. from comment #7)
> (In reply to Tijl Coosemans from comment #6)
>> I'd like to propose this alternate patch.  It updates the port to version
>> 1.5.0 instead of using a development version.
> 
> Considering the sort of "release-management" that GitHub seems to encourage,
> I doubt, using such a release ("version 1.5.0") will mean, what we usually
> mean by the term...
> 
> Because nothing in our ports-tree is really using libsrtp at the moment, we
> don't need to worry (much) about "legacy" code. I'd say, we may as well
> offer a snapshot of the current master-branch of the project.

The fix for the sha1_update symbol clash went into the 2_0_0_dev branch, not
the master branch.  The master branch currently contains version 1.5.1-pre. 
The 2_0_0_dev branch appears to be used for things that aren't backward
compatible with the 1.x series.  The library has also been renamed to libsrtp2
there.  I don't think it's a good idea to start using that.

>> It also enables the use of some crypto functions from libcrypto (OpenSSL) which
>> eliminates the sha1_update function from the library so it no longer conflicts
>> with the same function from polarssl.
> 
> So, we'll now have both OpenSSL and polarssl linked into libsrtp? If
> polarssl can not be easily replaced by OpenSSL (from base) completely,
> should we not use polarssl's implementation(s) of digests (like sha1)
> instead of -lcrypto's?

Polarssl isn't used by libsrtp.  It is used by net/belle-sip which is another
dependency of linphone.

-- 
You are receiving this mail because:
You are the assignee for the bug.