[Bug 199069] New USE_GITHUB has inconsistent DISTNAMEs for same GH_TAGNAME

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199069

--- Comment #1 from commit-hook at freebsd.org ---
A commit references this bug:

Author: bdrewery
Date: Tue Apr 28 18:44:17 UTC 2015
New revision: 384932
URL: https://svnweb.freebsd.org/changeset/ports/384932

Log:
  USE_GITHUB: For the new support, fix DISTNAME to be more consistent.

  When using GH_TAGNAME the DISTNAME would have GH_PROJECT and GH_ACCOUNT in
  it. When not using GH_TAGNAME it would not have this. Now both cases
  will add in the GH_PROJECT and GH_ACCOUNT.

  Add special care to ensure that the DISTVERSION is not added in twice. If
  a port does GH_TAGNAME=v${PORTVERSION} it will be added in twice though. For
  that case DISTVERSIONPREFIX=v should be set and no GH_TAGNAME should be used.

  empty() is used rather than (!defined || !${}) to support fmake.

  The purpose of setting DISTNAME at all in these cases is to make it more
clear
  that the distfile is from *GITHUB* and to avoid collisions if a project were
  to be renamed or moved. Without adding in GH_PROJECT and GH_ACCOUNT then
there
  are real risks that collisions on filenames would happen on renamed or moved
  projects, which is fairly common. A GITHUB-generated file may not match
  a custom-rolled or git-archive-rolled distfile.

  PR:        199069
  With hat:    portmgr
  Testing done:    All USE_GITHUB ports without GH_COMMIT were
checksum/fetch/extract/WRKSRC tested.

Changes:
  head/Mk/bsd.port.mk
  head/archivers/liblz4/distinfo
  head/astro/gpxloggerd/distinfo
  head/audio/gogglesmm/distinfo
  head/benchmarks/smhasher/distinfo
  head/comms/dump1090_mr/distinfo
  head/databases/php5-redis/distinfo
  head/devel/editline/distinfo
  head/devel/fstrm/distinfo
  head/devel/hub/distinfo
  head/devel/injeqt/distinfo
  head/devel/osc/distinfo
  head/devel/protobuf-c/distinfo
  head/devel/sdl2pp/distinfo
  head/graphics/libsixel/distinfo
  head/irc/insub/distinfo
  head/lang/chibi-scheme/distinfo
  head/mail/libetpan/distinfo
  head/mail/mu/distinfo
  head/mail/roundcube-contextmenu/distinfo
  head/math/openblas/distinfo
  head/multimedia/emby-server/distinfo
  head/multimedia/libass/distinfo
  head/multimedia/openh264/distinfo
  head/multimedia/plexhometheater/distinfo
  head/net/GeoIP/distinfo
  head/net/freevrrpd/distinfo
  head/net/geoipupdate/distinfo
  head/net/go-cs/distinfo
  head/net/google-daemon/distinfo
  head/net/google-startup-scripts/distinfo
  head/net/libilbc/distinfo
  head/net/libsrtp/distinfo
  head/net/shadowsocks-libev/distinfo
  head/net/syncthing/distinfo
  head/net-mgmt/icinga2/distinfo
  head/polish/libgadu/distinfo
  head/ports-mgmt/poudriere/distinfo
  head/print/indexinfo/distinfo
  head/security/libzrtpcppcore/distinfo
  head/security/passivedns/distinfo

-- 
You are receiving this mail because:
You are on the CC list for the bug.