[Bug 199737] [patch] comms/linrad : fix two bugs (fatal on gcc5)
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Mon Apr 27 17:46:49 UTC 2015
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199737
Bug ID: 199737
Summary: [patch] comms/linrad : fix two bugs (fatal on gcc5)
Product: Ports & Packages
Version: Latest
Hardware: Any
OS: Any
Status: New
Keywords: patch
Severity: Affects Only Me
Priority: ---
Component: Individual Port(s)
Assignee: hamradio at FreeBSD.org
Reporter: marino at FreeBSD.org
Assignee: hamradio at FreeBSD.org
Keywords: patch
Flags: maintainer-feedback?(hamradio at FreeBSD.org)
Created attachment 156048
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=156048&action=edit
Fix linrad on latest gcc
I checked linrad upstream, and they still haven't fixed these two bugs. I am
surprised they haven't been reported yet. Without these fixes, linrad cannot
be built with gcc5.
the menu.c patch simply reverses the order of the condition. One must check
the bounds constraint first! It's a pretty dumb mistake but I've seen this
kind before.
The second one fails because -Werror is set. This took me a while because I
couldn't figure out the relationship between ADCHANS and rxchan. In any case,
setting 4 locations per channel did indeed allow the array to be big enough.
(at first I thought the loop was running too high, but I finally determined the
array was too small).
These were found on DragonFly that uses gcc5.
This patch has not been tested on FreeBSD but I can't how it could possibly
fail.
It would be good if the ham@ maintainer reports the issue upstream.
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the freebsd-ports-bugs
mailing list