[Bug 199343] sysutils/moosefs-chunkserver: Upgrade to 2.0.63-1

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199343

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koobs at FreeBSD.org
           Keywords|                            |needs-patch, needs-qa
              Flags|                            |maintainer-feedback?(freebs
                   |                            |d at moosefs.com)

--- Comment #2 from Kubilay Kocak <koobs at FreeBSD.org> ---
On initial triage:

* Updates must be provided in unified diff format (svn diff) not as archives
* You'll want to run all of your patches/ports/PR's through:

  1) portlint -AC (it can be found in ports-mgmt/portlint)
  2) poudriere testport (or bulk -t) See:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing-poudriere.html

* I think a MASTER/SLAVE port setup might be better for the moosefs-* ports 
instead of including a Makefile.common. See:

http://www2.au.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-masterdir

* COMMENT should be a short description of the port, not just it's
functionality:

COMMENT=    Managing the whole filesystem and storing metadata

Says nothing about MooseFS or the component that is included.

Something like the following may be better:

COMMENT= Moose File System: Master & Metadata Server

* The following look like workarounds for an issue elsewhere:

DISTNAME=    ${PORTNAME}-${PORTVERSION}-${PORTREVISION}
WRKSRC=        ${WRKDIR}/${PORTNAME}-${PORTVERSION}

In particular PORTREVISION shouldn't be a part of DISTNAME.

See:
http://www2.au.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-distfiles

If you need assistance with any of this, we are available in #freebsd-ports on
freenode or #bsdports on efnet

-- 
You are receiving this mail because:
You are the assignee for the bug.