[Bug 199403] [patch] x11-toolkits/wxPython30: update to 3.0.2.0, drop GCC dep and fix bugs
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Sun Apr 12 18:27:05 UTC 2015
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199403
Bug ID: 199403
Summary: [patch] x11-toolkits/wxPython30: update to 3.0.2.0,
drop GCC dep and fix bugs
Product: Ports & Packages
Version: Latest
Hardware: Any
OS: Any
Status: New
Keywords: patch
Severity: Affects Some People
Priority: ---
Component: Individual Port(s)
Assignee: freebsd-ports-bugs at FreeBSD.org
Reporter: matthew at reztek.cz
Keywords: patch
Created attachment 155522
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=155522&action=edit
update and bugfix wxPython30
x11-toolkits/wxPython30 recently got smacked with USE_GCC.
Quoting that commit:
"It turns out that wxPython30 won't build with clang at all. The c++ code
is illegal according to clang (e.g. illegal cast), so remove the
USES=compiler setting and replace with USE_GCC=yes. Tested on F8 and F10.
I apologize for adding the GCC dependence for F10+ users but I didn't see
any other simple fix."
However, I see a much simpler fix thatn pulling in GCC, which is to use a
static_cast instead of reinterpret_cast. Building with Clang exposed two other
bugs in the code thanks to the actually useful warnings.
1) if (depth = 32) should be if (depth == 32), corrected by updating to 3.0.2
2) two functions return a pointer to a string allocated on the local stack,
corrected by using static allocation for the string constant
It is much better to fix the bugs than to use a compiler that accepts buggy
code.
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the freebsd-ports-bugs
mailing list