ports/190088: [patch] Fix for upstream bug #94259: Useless use of concatenation (.) or string in void context
Andrew Walker
awalker at sourcefire.com
Wed May 21 20:10:03 UTC 2014
>Number: 190088
>Category: ports
>Synopsis: [patch] Fix for upstream bug #94259: Useless use of concatenation (.) or string in void context
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Wed May 21 20:10:02 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Andrew Walker
>Release:
>Organization:
Sourcefire, Inc.
>Environment:
>Description:
Module errors at due to misplaced parenthesis in Helper.pm
Upstream bug: https://rt.cpan.org/Public/Bug/Display.html?ShowHeaders=1;id=94259
>How-To-Repeat:
>Fix:
Apply attached patch to resolve the issue and increment PORTREVISION.
Patch attached with submission follows:
Index: Makefile
===================================================================
--- Makefile (revision 354758)
+++ Makefile (working copy)
@@ -3,7 +3,7 @@
PORTNAME= JSON-Schema
PORTVERSION= 0.015
-PORTREVISION= 1
+PORTREVISION= 2
CATEGORIES= devel perl5
MASTER_SITES= CPAN
PKGNAMEPREFIX= p5-
Index: files/patch-lib__JSON__Schema__Helper.pm
===================================================================
--- files/patch-lib__JSON__Schema__Helper.pm (revision 0)
+++ files/patch-lib__JSON__Schema__Helper.pm (working copy)
@@ -0,0 +1,32 @@
+--- ./lib/JSON/Schema/Helper.pm.orig 2014-05-21 15:43:01.000000000 -0400
++++ ./lib/JSON/Schema/Helper.pm 2014-05-21 15:49:17.000000000 -0400
+@@ -308,12 +308,12 @@
+ if ((defined $schema->{'minimumCanEqual'} and not $schema->{'minimumCanEqual'})
+ or $schema->{'exclusiveMinimum'})
+ {
+- $addError->("must be greater than minimum value '" . $schema->{'minimum'}) . "'"
++ $addError->("must be greater than minimum value '" . $schema->{'minimum'} . "'")
+ if $value lt $schema->{'minimum'};
+ }
+ else
+ {
+- $addError->("must be greater than or equal to minimum value '" . $schema->{'minimum'}) . "'"
++ $addError->("must be greater than or equal to minimum value '" . $schema->{'minimum'} . "'")
+ if $value le $schema->{'minimum'};
+ }
+ }
+@@ -336,12 +336,12 @@
+ if ((defined $schema->{'maximumCanEqual'} and not $schema->{'maximumCanEqual'})
+ or $schema->{'exclusiveMaximum'})
+ {
+- $addError->("must be less than or equal to maximum value '" . $schema->{'maximum'}) . "'"
++ $addError->("must be less than or equal to maximum value '" . $schema->{'maximum'} . "'")
+ if $value gt $schema->{'maximum'};
+ }
+ else
+ {
+- $addError->("must be less than or equal to maximum value '" . $schema->{'maximum'}) . "'"
++ $addError->("must be less than or equal to maximum value '" . $schema->{'maximum'} . "'")
+ if $value ge $schema->{'maximum'};
+ }
+ }
Property changes on: files/patch-lib__JSON__Schema__Helper.pm
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list