ports/189777: [patch] www/codeigniter staging, change url
Zsolt Udvari
udvzsolt at gmail.com
Sun May 18 15:50:01 UTC 2014
The following reply was made to PR ports/189777; it has been noted by GNATS.
From: Zsolt Udvari <udvzsolt at gmail.com>
To: Guido Falsi <madpilot at freebsd.org>
Cc: bug-followup at freebsd.org, appleboy.tw at gmail.com
Subject: Re: ports/189777: [patch] www/codeigniter staging, change url
Date: Sun, 18 May 2014 17:43:35 +0200
To maintainer: do you think files/codeigniter-*.conf.in are needed?
I think it's enough to ship a sample apache configuration file (if
build with APACHE support) and show a simple message with an attention
to check, configure and restart webserver (apache, lighttpd, nginx,
etc.).
I think the "PROD" option should drop - the developer can configure
his/her webserver. And this option is useful _only_ with Apache -
doesn't include any lighttpd/nginx config.
And I think the PHP_CGI check is unnecessary too because of it's
Apache-specific.
Summary (of my thinks):
- drop PROD option (and "confighelp" target too)
- drop PHP_CGI check and cgi-specific message
- drop apache configuration files, except a simple one (or maybe can
install apache config file into codeigniter's doc/examplesdir without
any APACHE-option)
- drop any option-specific message
- message content is: attention about check/config/reload webserver,
create a correct index.php from index.php.sample (I think shouldn't
create index.php because it's modified because of database settings -
but I think nobody use this index.php, for example I'm copying it into
my ~/public_html/app and modify this copied version). Maybe a simple
plus message about production/develop installation (point to
codeigniter/user_guide/installation/index.html)
With this changes the port will be more simplier. If you think these
changes are correct I'll create a patch.
Zsolt
2014-05-14 22:51 GMT+02:00 Guido Falsi <madpilot at freebsd.org>:
> While looking at this patch I noticed it has a problem.
>
> The staging conversion is incomplete.
>
> The port is still echoing pkg-message by itself, which is unnecessary
> with staging.
>
> The port also echoes various user message during installation, this is
> wrong when using staging, since thee messages will appear at the wrong
> time, and will never be seen by people using binary packages.
>
> Such messages should be moved to the pkg-message, or, is conditionally
> shown, a pkg-install script should be created to show them if necessary.
>
> Can this patch be fixed keeping all this in mind?
>
> The port is also redefining WWWDIR to it's default value, why is this
> needed?
>
> Thanks in advance.
>
> --
> Guido Falsi <madpilot at FreeBSD.org>
More information about the freebsd-ports-bugs
mailing list