ports/189158: update for ports/sysutils/zfs-snapshot-clean
Akinori MUSHA
knu at iDaemons.org
Wed May 14 07:14:38 UTC 2014
Hi,
Thanks for the work!
The patch looks good, but I have a couple of questions.
> 1. There is no PATH setting.
Why would you need PATH to be set in this command? I mean, which
exactly commands are not in the default paths? I would rather append
or prepend neccessary directories to PATH than to completely override
it.
> 3. On Solaris, This script does not work. Because /bin/sh on Solaris
> does not support "$(command)" syntax.
I think this command tries to invoke itself with /usr/xpg4/bin/sh if
`local` is missing. Which in the following is the case?
a. /bin/sh does support `local` but does not support $().
b. /bin/sh does not support `local` and /usr/xpg4/bin/sh does not
support $().
I'm asking this because the $(...) construct has been specified in
POSIX/SUS for a very long time, and I expect /usr/xpg4/bin/sh to
support it.
Best Regards,
--
Akinori MUSHA / https://akinori.org/
More information about the freebsd-ports-bugs
mailing list