[Bug 191152] [NEW PORT] x11-fonts/hasklig

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191152

--- Comment #2 from 6yearold at gmail.com ---
(In reply to Raphael Kubo da Costa from comment #1)
> > DISTNAME=Hasklig-${PORTVERSION}
> 
> Missing a tab here.
> 
> > BUILD_DEPENDS=fc-cache:${PORTSDIR}/x11-fonts/fontconfig
> > RUN_DEPENDS:=	${BUILD_DEPENDS}
> 
> I believe fontconfig can be declared as a runtime dependency only, as it is
> only invoked when the port is installed and deinstalled. In any case, the
> second assignment could be a normal one, since nothing else changes
> BUILD_DEPENDS.
> 
> > @unexec /bin/rm %D/%%FONTSDIR%%/fonts.cache-1 2>/dev/null || /usr/bin/true
> > @dirrm %%FONTSDIR%%
> > @exec %%LOCALBASE%%/bin/fc-cache -f -v %D/%%FONTSDIR%% || /usr/bin/true
> 
> Please use the @fc keyword instead:
> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-
> keywords.html

I've stolen this Makefile from x11-fonts/ubuntu-font. And, BTW, i still have no
idea how fontconfig gets run on install.

Ok, i'll fix your points and attach a new patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.