[Bug 185363] [NEW PORT] revive port devel/thistest

[bz-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=185363

John Marino <marino at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marino at FreeBSD.org

--- Comment #4 from John Marino <marino at FreeBSD.org> ---
I'm also confused, even after the patch-on-patch.

The title says this replaces port "devel/thistest".
But the patch-on-patch says the new port is "devel/src-thistest-aegis" which
seems kind of like nonsense to me.  In fact, it seems like the name of the port
follows the name of the tarball.

Oh, and the original diff is not in unified patch format.  


Is it STAGE safe?


To recap my concerns:
1) The portname looks like it should be "thistest", not "src-thistest-aegis"
(use DISTNAME to change name of distfile, not PORTNAME)
2) It may not be jobs safe
3) It's in two different patches, one of which isn't unified format
4) The pkg-descr is still very weak (although to be fair the original port's
description was also extremely weak)
5) I'd like to hear that it was tested with poudriere

If those were fixed, a brand new diff (or shar as is technically required, but
I'm not going to) is submitted, and it has some reasonable testing then I'll
pick this up.

-- 
You are receiving this mail because:
You are the assignee for the bug.