[Bug 190740] New: webplugin sym links broken (e.g., multimedia/totem)
bz-noreply at freebsd.org
bz-noreply at freebsd.org
Sat Jun 7 01:59:41 UTC 2014
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=190740
Bug ID: 190740
Summary: webplugin sym links broken (e.g., multimedia/totem)
Product: Ports Tree
Version: Latest
Hardware: Any
OS: Any
Status: Needs Triage
Severity: Affects Only Me
Priority: ---
Component: Infrastructure
Assignee: freebsd-ports-bugs at FreeBSD.org
Reporter: z7dr6ut7gs at snkmail.com
Created attachment 143475
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=143475&action=edit
fix webplugin sym links due to make eval order problems
I think webplugin sym links are still broken even after:
==============
r333783 | jkim | 2013-11-14 11:43:25 -0700 (Thu, 14 Nov 2013) | 6 lines
Changed paths:
M /head/Mk/Uses/webplugin.mk
Fix symlink when PKGBASE, WEBPLUGIN_DIR, and WEBPLUGIN_NAME are not defined.
The deeply nested expression for .for loop cannot be completely evaluated at
the time of loop expansion because PKGBASE will be assigned much later.
Approved by: bapt
==============
The issue is the same as what is described in the commit message.
When WEBPLUGIN_NAME is undefined by the port, WEBPLUGIN_DIR (which
references WEBPLUGIN_NAME) will also not have the right value until
after PKGBASE is defined.
But the :S substitution is done before that and thus before
WEBPLUGIN_DIR really gets the value we want it to have (not at the
time the ln command is run).
For example, in multimedia/totem, I see the following during 'make stage':
.
.
gmake[1]: Leaving directory `/usr/ports/multimedia/totem/work/totem-2.32.0'
install -d
/usr/ports/multimedia/totem/work/stage/usr/local/lib/browser_plugins/symlinks/gecko
/bin/ln -sf /usr/local/lib/browser_plugins//libtotem-cone-plugin.so
/usr/ports/multimedia/totem/work/stage/usr/local/lib/browser_plugins/symlinks/gecko/
.
.
And that sym link is broken.
It should be:
/bin/ln -sf /usr/local/lib/browser_plugins/totem/libtotem-cone-plugin.so
/usr/ports/multimedia/totem/work/stage/usr/local/lib/browser_plugins/symlinks/gecko/
^^^^^
Attached is a fix that avoids the :S evaluation that happens too soon.
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the freebsd-ports-bugs
mailing list