ports/185908: [PATCH] irc/weechat, irc/weechat-devel: Change default options (TLS, scripts support)

[Jean-Sébastien Pédron]

>Number:         185908
>Category:       ports
>Synopsis:       [PATCH] irc/weechat, irc/weechat-devel: Change default options (TLS, scripts support)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 20 13:20:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Jean-Sébastien Pédron
>Release:        10.0-RC4
>Organization:
The FreeBSD Project
>Environment:
FreeBSD viking.yzserv.com 10.0-RC4 FreeBSD 10.0-RC4 #0 r260130: Tue Dec 31 17:10:01 UTC 2013     root at snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
Now that we have binary packages, I find that the default options on WeeChat are not sensible anymore for an end-user.

Here's a patch that:
    o  enables TLS support
    o  enables all scripting languages
    o  enables COLOR256

The patch also removes the pre-configure target which previously displayed a message about ncurses' EXTCOLORS option. This option seems gone, so no need to have this warning.

The patch modifies irc/weechat and irc/weechat-devel in a same way.

What do you think?
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: irc/weechat/Makefile
===================================================================
--- irc/weechat/Makefile	(revision 340383)
+++ irc/weechat/Makefile	(working copy)
@@ -23,7 +23,7 @@ LIB_DEPENDS+=	libcurl.so:${PORTSDIR}/ftp/curl \
 
 OPTIONS_DEFINE=	RUBY PYTHON PERL TCL LUA CHARSET BACKTRACE ASPELL \
 		GNUTLS NLS DOCUMENTATION COLOR256 ICON MANPAGES
-OPTIONS_DEFAULT=CHARSET MANPAGES
+OPTIONS_DEFAULT=RUBY PYTHON PERL TCL LUA CHARSET GNUTLS COLOR256 MANPAGES
 
 BACKTRACE_DESC=	Provide crash backtraces
 CHARSET_DESC=	Charset conversion support
@@ -180,17 +180,6 @@ post-patch:
 	@${REINPLACE_CMD} -e '/^# icon$$/,/^$$/d' ${WRKSRC}/CMakeLists.txt
 .endif
 
-pre-configure:
-.if ${PORT_OPTIONS:MCOLOR256}
-	@${ECHO_MSG} ""
-	@${ECHO_MSG} "==> You have selected the ncurses 256 color option. Please ensure that"
-	@${ECHO_MSG} "==> the devel/ncurses port is built with the EXTCOLORS option enabled."
-	@${ECHO_MSG} "==>"
-	@${ECHO_MSG} "==> Press Ctrl-C now if you want to re-configure."
-	@${ECHO_MSG} ""
-	@sleep 5
-.endif
-
 post-install:
 .if ${PORT_OPTIONS:MMANPAGES} && !defined(MAINTAINER_MODE)
 	${INSTALL_MAN} ${WRKDIR}/manpages/weechat.1 ${STAGEDIR}${PREFIX}/man/man1
Index: irc/weechat-devel/Makefile
===================================================================
--- irc/weechat-devel/Makefile	(revision 340383)
+++ irc/weechat-devel/Makefile	(working copy)
@@ -36,7 +36,8 @@ WRKSRC=		${WRKDIR}/${PORTNAME}-${GITREV}
 
 OPTIONS_DEFINE=	RUBY PYTHON PERL TCL LUA CHARSET BACKTRACE DEBUG ASPELL \
 		GNUTLS NLS DOCUMENTATION COLOR256 ICON MANPAGES
-OPTIONS_DEFAULT=CHARSET BACKTRACE DEBUG MANPAGES
+OPTIONS_DEFAULT=RUBY PYTHON PERL TCL LUA CHARSET GNUTLS COLOR256 MANPAGES \
+		BACKTRACE DEBUG
 
 BACKTRACE_DESC=	Provide crash backtraces
 CHARSET_DESC=	Charset conversion support
@@ -195,17 +196,6 @@ post-patch:
 	@${REINPLACE_CMD} -e '/^# icon$$/,/^$$/d' ${WRKSRC}/CMakeLists.txt
 .endif
 
-pre-configure:
-.if ${PORT_OPTIONS:MCOLOR256}
-	@${ECHO_MSG} ""
-	@${ECHO_MSG} "==> You have selected the ncurses 256 color option. Please ensure that"
-	@${ECHO_MSG} "==> the devel/ncurses port is built with the EXTCOLORS option enabled."
-	@${ECHO_MSG} "==>"
-	@${ECHO_MSG} "==> Press Ctrl-C now if you want to re-configure."
-	@${ECHO_MSG} ""
-	@sleep 5
-.endif
-
 post-install:
 .if ${PORT_OPTIONS:MMANPAGES} && !defined(MAINTAINER_MODE)
 	${INSTALL_MAN} ${WRKDIR}/manpages/weechat.1 ${STAGEDIR}${PREFIX}/man/man1


>Release-Note:
>Audit-Trail:
>Unformatted: