ports/184161: multimedia/gpac-mp4box missing dependency

[Ronald F.Guilmette]

>Number:         184161
>Category:       ports
>Synopsis:       multimedia/gpac-mp4box missing dependency
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 22 07:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Ronald F. Guilmette
>Release:        FreeBSD 9.1-RELEASE amd64
>Organization:
entr0py
>Environment:

FreeBSD 9.1-RELEASE amd64

>Description:

Attempts to build (or upgrade to) the current gpac-mp4box-0.5.0 port will
fail horribly, with many compile time errors, as shown below, if the only
version of multimedia/gpac-libgpac currently installed is some version of
the gpac-libgpac port PRIOR TO version gpac-libgpac-0.5.x,x.

The problem is resolved by MANUALLY first upgrading to the latest version
of gpac-libgpac, i.e. version 0.5.x,x.

Quite obviously, there is a missing dependency, and the gpac-mp4box-0.5.0
port needs to be fixed so that it will have a hard dependency upon
gpac-libgpac-0.5.x,x, i.e. one which will force a build and install of
that version of that port if it is not already installed.

Here are the errors I obtained when attempting to simply upgrade my
existing multimedia/gpac-mp4box port, due to its lack of proper
dependency rules:

root at segfault:/usr/ports/multimedia/gpac-mp4box # make
===>  License LGPL21 accepted by the user
===> Fetching all distfiles required by gpac-mp4box-0.5.0 for building
===>  Extracting for gpac-mp4box-0.5.0
=> SHA256 Checksum OK for gpac-0.5.0.tar.gz.
===>  Patching for gpac-mp4box-0.5.0
===>   gpac-mp4box-0.5.0 depends on shared library: libgpac.so - found
===>  Configuring for gpac-mp4box-0.5.0
===>  Building for gpac-mp4box-0.5.0
cd /usr/ports/multimedia/gpac-mp4box/work/gpac/applications/mp4box && cc -O2 -pipe -I/usr/local/include -fno-strict-aliasing  -L/usr/local/lib -lgpac -o mp4box  filedump.c fileimport.c live.c main.c
filedump.c: In function 'set_cover_art':
filedump.c:142: warning: assignment makes pointer from integer without a cast
filedump.c: In function 'dump_timed_text_track':
filedump.c:919: error: 'GF_ISOM_MEDIA_SUBT' undeclared (first use in this function)
filedump.c:919: error: (Each undeclared identifier is reported only once
filedump.c:919: error: for each function it appears in.)
filedump.c: In function 'DumpTrackInfo':
filedump.c:1135: error: 'GF_ISOM_SUBTYPE_AVC2_H264' undeclared (first use in this function)
filedump.c:1136: error: 'GF_ISOM_SUBTYPE_SVC_H264' undeclared (first use in this function)
filedump.c:1137: error: 'GF_ISOM_SUBTYPE_LSR1' undeclared (first use in this function)
filedump.c:1158: error: 'GPAC_OTI_VIDEO_MPEG4_PART2' undeclared (first use in this function)
filedump.c:1176: error: 'GPAC_OTI_VIDEO_AVC' undeclared (first use in this function)
filedump.c:1188: warning: assignment makes pointer from integer without a cast
filedump.c:1197: error: too many arguments to function 'gf_avc_get_sps_info'
filedump.c:1213: error: too many arguments to function 'gf_avc_get_sps_info'
filedump.c:1235: error: 'GPAC_OTI_IMAGE_JPEG' undeclared (first use in this function)
filedump.c:1239: error: 'GPAC_OTI_IMAGE_PNG' undeclared (first use in this function)
filedump.c:1243: error: 'GPAC_OTI_IMAGE_JPEG_2000' undeclared (first use in this function)
filedump.c:1264: error: 'GPAC_OTI_AUDIO_AAC_MPEG2_MP' undeclared (first use in this function)
filedump.c:1265: error: 'GPAC_OTI_AUDIO_AAC_MPEG2_LCP' undeclared (first use in this function)
filedump.c:1266: error: 'GPAC_OTI_AUDIO_AAC_MPEG2_SSRP' undeclared (first use in this function)
filedump.c:1268: error: 'GPAC_OTI_AUDIO_AAC_MPEG4' undeclared (first use in this function)
filedump.c:1279: error: 'GF_M4ADecSpecInfo' has no member named 'has_ps'
filedump.c:1286: error: 'GPAC_OTI_AUDIO_MPEG2_PART3' undeclared (first use in this function)
filedump.c:1287: error: 'GPAC_OTI_AUDIO_MPEG1' undeclared (first use in this function)
filedump.c:1323: error: 'GPAC_OTI_AUDIO_EVRC_VOICE' undeclared (first use in this function)
filedump.c:1324: error: 'GPAC_OTI_AUDIO_SMV_VOICE' undeclared (first use in this function)
filedump.c:1325: error: 'GPAC_OTI_AUDIO_13K_VOICE' undeclared (first use in this function)
filedump.c:1344: error: 'GPAC_OTI_SCENE_AFX' undeclared (first use in this function)
...
etc etc

>How-To-Repeat:

Try to build (or upgrade to) the current gpac-mp4box-0.5.0 port when all
you have installed is some version of gpac-libgpac prior to 0.5.x,x.

>Fix:

Add a dependency into the build rules for gpac-mp4box-0.5.0 which will
have the effect of forcing a build and install of gpac-libgpac-0.5.x,x.
>Release-Note:
>Audit-Trail:
>Unformatted: