ports/176758: [patch] samba talloc + tdb incorrect w/ non-default LOCALBASE

[Daniel Hagerty]

>Number:         176758
>Category:       ports
>Synopsis:       [patch] samba talloc + tdb incorrect w/ non-default LOCALBASE
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 08 18:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Daniel Hagerty
>Release:        FreeBSD 9.1-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD perdition.linnaean.org 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243710+9a57fd8: Fri Jan 25 23:38:46 EST 2013 hag at yall.linnaean.org:/sys/amd64/compile/LINNAEAN64 amd64

	ports svn r313265

>Description:
	The samba related ports talloc + tdb don't build correctly if
	LOCALBASE is set to a non-default value.  They unconditionally
	install to /usr/local, but dependant ports like samba will
	fail to build due to expecting the include files (and
	presumably any libraries, if it got that) under LOCALBASE.

	This is probably due to these ports having a USE_CONFIGURE=yes
	that is not actually GNU_CONFIGURE=yes .  I didn't dig very
	deeply, I just smashed with the hammer until I got my build.

>How-To-Repeat:
	Set LOCALBASE to a non-default value in make.conf.  Build tdb
	and/or talloc.  Build samba.  Observe fail.

>Fix:

commit a3d5cb38c02eee986337bdc23182dd8b46445cdc
Author: Daniel Hagerty <hag at linnaean.org>
Date:   Sun Feb 24 22:00:39 2013 -0500

    Samba related bits don't do LOCALBASE correctly

diff --git a/databases/tdb/Makefile b/databases/tdb/Makefile
index 1f9ed15..e03b8a7 100644
--- a/databases/tdb/Makefile
+++ b/databases/tdb/Makefile
@@ -51,6 +51,8 @@ MAKE_ENV+=		NOCOLOR=yes
 
 CONFIGURE_ARGS+=	--mandir=${MANPREFIX}/man
 
+CONFIGURE_ARGS+=	--prefix=${LOCALBASE}
+
 .if !defined(DISABLE_MAKE_JOBS) && !defined(MAKE_JOBS_UNSAFE)
 .if defined(MAKE_JOBS_SAFE) || defined(FORCE_MAKE_JOBS)
 CONFIGURE_ARGS+=	--jobs=${MAKE_JOBS_NUMBER}
diff --git a/devel/talloc/Makefile b/devel/talloc/Makefile
index 9b5797a..e1a075c 100644
--- a/devel/talloc/Makefile
+++ b/devel/talloc/Makefile
@@ -45,6 +45,8 @@ MAKE_ENV+=		NOCOLOR=yes
 
 CONFIGURE_ARGS+=	--mandir=${MANPREFIX}/man
 
+CONFIGURE_ARGS+=	--prefix=${LOCALBASE}
+
 .if !defined(DISABLE_MAKE_JOBS) && !defined(MAKE_JOBS_UNSAFE)
 .if defined(MAKE_JOBS_SAFE) || defined(FORCE_MAKE_JOBS)
 CONFIGURE_ARGS+=	--jobs=${MAKE_JOBS_NUMBER}


>Release-Note:
>Audit-Trail:
>Unformatted: