ports/179569: textproc/refdb: Fatal error: Call-time pass-by-reference has been removed in /usr/local/share/refdb/www/index.php on line 1531

[O. Hartmann]

>Number:         179569
>Category:       ports
>Synopsis:       textproc/refdb: Fatal error: Call-time pass-by-reference has been removed in /usr/local/share/refdb/www/index.php on line 1531
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 15 10:50:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     O. Hartmann
>Release:        FreeBSD 10..0-CURRENT/amd64 FreeBSD 9.1-STABLE/amd64
>Organization:
FU Berlin
>Environment:
>Description:
If someone is using texproc/refdb's PHP web interface which is in some cases very convenient, this one will run into problems on more modern php5 implementations, since the index.php file of refdb's web interface complains about a call by reference failure (it seems to be YAZ, but I'm not sure).

I simply circumvented this problem by following the PHP error logs advice to check and correct and I "corrected" the call by reference simply by removing the ampersand in the call shown in the patch attached.
>How-To-Repeat:
Install textproc/refdb on a modern FreeBSD 9/10 by using most recent PHP5, yaz and Apache22 or Apache24.
>Fix:
Modify line 1531 in phpweb/index.php.in as shown in the attached patch.

Patch attached with submission follows:

diff -Nur refdb.orig/files/patch-phpweb-index.php.in refdb/files/patch-phpweb-index.php.in
--- refdb.orig/files/patch-phpweb-index.php.in	1970-01-01 01:00:00.000000000 +0100
+++ refdb/files/patch-phpweb-index.php.in	2013-06-15 12:39:03.000000000 +0200
@@ -0,0 +1,18 @@
+--- phpweb/index.php.in.orig	2013-06-15 12:37:55.000000000 +0200
++++ phpweb/index.php.in	2013-06-15 12:38:21.000000000 +0200
+@@ -1528,7 +1528,7 @@
+ 	 // Mapping CCL terms to RPN as defined above (bib1) for each search 
+ 	 yaz_ccl_conf($id[$i], $bib1);
+ 	 // Parse input against yaz_ccl_conf; if error report message; defines cclresult as output of parsing
+-	 if (!yaz_ccl_parse($id[$i], $term, &$cclresult)) {
++	 if (!yaz_ccl_parse($id[$i], $term, $cclresult)) {
+ 	   echo '<p>Error: ' . $cclresult["errorstring"] . '</p><p><a href=\"index.php?thisPage=External databases\">Clear results</a></p>';
+ 	   continue;
+ 	 }
+@@ -1791,4 +1791,4 @@
+ // close out the html
+ echo "    </body>\n";
+ echo "</html>\n";
+-?>
+\ No newline at end of file
++?>


>Release-Note:
>Audit-Trail:
>Unformatted: