ports/184560: dns/bind99 compile failure using set GSSAPI or unset XML

[Dewayne]

>Number:         184560
>Category:       ports
>Synopsis:       dns/bind99 compile failure using set GSSAPI or unset XML
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 07 09:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Dewayne
>Release:        9.2 Stable
>Organization:
>Environment:
FreeBSD b1.hs 9.2-STABLE FreeBSD 9.2-STABLE #0: Tue Dec  3 12:24:13 EST 2013     root@:/usr/obj/prod/usr/src/sys/hqdev-amd64-padlock-smp-vga                        i386

>Description:
Samba4 now requires bind with gssapi to maintain DNS securely. Using options
unset GSSAPI
bind99 compiles and builds correctly.

However with wither set GSSAPI, the compilation fails as follows:

make __MAKE_CONF=/dev/null -DBATCH 
checking for gcc... cc
checking whether the C compiler works... no
configure: error: in `/var/ports/usr/ports/dns/bind99/work/bind-9.9.4':
configure: error: C compiler cannot create executables
See `config.log' for more details
===>  Script "configure" failed unexpectedly.
Please report the problem to erwin at FreeBSD.org [maintainer] and attach the
"/var/ports/usr/ports/dns/bind99/work/bind-9.9.4/config.log" including the
output of the failure of your make command. Also, it might be a good idea to
provide an overview of all packages installed on your system (e.g. a
/usr/sbin/pkg_info -Ea).
*** [do-configure] Error code 1

An erroneous message, as it's actually because there is no libgssapi_krb5, when the system is built without heimdal (kerberos).
>How-To-Repeat:
cd /usr/ports/dns/bind99 && make __MAKE_CONF=/dev/null clean deinstall package

AND the system does NOT have kerberos (specifically heimdal) built in the system (so there is no libgssapi_krb5).

>Fix:
--- Makefile.orig       2013-12-07 20:02:29.000000000 +1100
+++ Makefile    2013-12-07 20:19:53.000000000 +1100
@@ -164,7 +164,11 @@

 .if ${PORT_OPTIONS:MGSSAPI}
 CONFIGURE_ARGS+=       --with-gssapi
+.if defined(HEIMDAL_HOME)
+LDFLAGS+=              -L${LIBDIR} -lgssapi -lkrb5
+.else
 LDFLAGS+=              -L${LIBDIR} -lgssapi_krb5
+.endif
 .else
 CONFIGURE_ARGS+=        --without-gssapi
 .endif

I'm *assuming* that when HEIMDAL_HOME is defined, that someone is using the heimdal port.  There's needs to be a better test for when the heimdal port is used, as I intentionally define HEIMDAL_HOME=/usr.  

>Release-Note:
>Audit-Trail:
>Unformatted: