ports/181617: [patch] misc/window: fix build with clang, add LICENSE and more

Boris Samorodov bsam at FreeBSD.org
Wed Aug 28 12:50:03 UTC 2013


>Number:         181617
>Category:       ports
>Synopsis:       [patch] misc/window: fix build with clang, add LICENSE and more
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 28 12:50:02 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Boris Samorodov
>Release:        FreeBSD 10.0-CURRENT
>Organization:
BSDprint
>Environment:
FreeBSD bsam.int.wart.ru 10.0-CURRENT FreeBSD 10.0-CURRENT #36 r254961: Wed Aug 28 02:04:00 SAMT 2013     bsam at bsam.int.wart.ru:/usr/obj/usr/src/sys/BB64X  amd64
>Description:
The ports fails to build with clang:
-----
cmd.c:297:3: error: non-void function 'setselwin' should return a value [-Wreturn-type]
                return;
                ^
-----
>How-To-Repeat:

>Fix:
. fix build with clang (CFLAGS+=-Wno-return-type);
. trim Makefile headers;
. reword COMMENT;
. add LICENSE (BSD);
. remove check for unsupported FreeBSD versions (<800093).

Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 325431)
+++ Makefile	(working copy)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	window
-# Date created:				31 May 2009
-# Whom:					Tom Rhodes <trhodes at FreeBSD.org>
-#
+# Created by: Tom Rhodes <trhodes at FreeBSD.org>
 # $FreeBSD$
-#
 
 PORTNAME=	window
 PORTVERSION=	1.0
@@ -11,15 +7,12 @@
 MASTER_SITES=	http://people.FreeBSD.org/~trhodes/
 
 MAINTAINER=	trhodes at FreeBSD.org
-COMMENT=	The FreeBSD usr.bin/window application
+COMMENT=	Window environment on ASCII terminals
 
-.include <bsd.port.pre.mk>
+LICENSE=	BSD
 
-.if ${OSVERSION} < 800093
-IGNORE=		window-1.0 is still part of the base system
-.endif
-
 WRKSRC=		${WRKDIR}/window
+CFLAGS+=	-Wno-return-type
 
 MAN1=		window.1
 PLIST_FILES=	bin/window
@@ -28,4 +21,4 @@
 	${INSTALL_PROGRAM} ${WRKSRC}/window ${PREFIX}/bin
 	${INSTALL_DATA} ${WRKSRC}/${MAN1} ${PREFIX}/man/man1
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>


>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-ports-bugs mailing list