ports/181521: [patch] multimedia/gstreamer-ffmpeg: enable mp3 decoder fallback

[Jan Beich]

>Number:         181521
>Category:       ports
>Synopsis:       [patch] multimedia/gstreamer-ffmpeg: enable mp3 decoder fallback
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 25 07:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Jan Beich
>Release:        
>Organization:
>Environment:
>Description:
Mark ffdec_mp3 as "marginal" to allow decoder fallback in absence of
"primary" plugins such as fluendo or mad. It was originally marked
"none" for reasons that're obsolete now e.g., broken seeking.

This should help firefox24 to have mp3 playback support by default.

>How-To-Repeat:
$ gst-launch-0.10 playbin2 uri=file:///path/to/foo.mp3
Setting pipeline to PAUSED ...
Pipeline is PREROLLING ...
Missing element: MPEG-1 Layer 3 (MP3) decoder
WARNING: from element /GstPlayBin2:playbin20/GstURIDecodeBin:uridecodebin0: No decoder available for type 'audio/mpeg, mpegversion=(int)1, mpegaudioversion=(int)1, layer=(int)3, rate=(int)44100, channels=(int)2, parsed=(boolean)true'.
Additional debug info:
gsturidecodebin.c(874): void unknown_type_cb(GstElement *, GstPad *, GstCaps *, GstURIDecodeBin *) (): /GstPlayBin2:playbin20/GstURIDecodeBin:uridecodebin0
ERROR: from element /GstPlayBin2:playbin20/GstURIDecodeBin:uridecodebin0/GstDecodeBin2:decodebin20: Your GStreamer installation is missing a plug-in.
Additional debug info:
gstdecodebin2.c(3576): gboolean gst_decode_bin_expose(GstDecodeBin *) (): /GstPlayBin2:playbin20/GstURIDecodeBin:uridecodebin0/GstDecodeBin2:decodebin20:
no suitable plugins found
ERROR: pipeline doesn't want to preroll.
Setting pipeline to NULL ...
Freeing pipeline ...

>Fix:
--- patch-mp3 begins here ---
--- ext/ffmpeg/gstffmpegdec.c~
+++ ext/ffmpeg/gstffmpegdec.c
@@ -3042,9 +3042,6 @@ gst_ffmpegdec_register (GstPlugin * plug
       case CODEC_ID_SIPR:
         rank = GST_RANK_SECONDARY;
         break;
-      case CODEC_ID_MP3:
-        rank = GST_RANK_NONE;
-        break;
         /* TEMPORARILY DISABLING AC3/EAC3/DTS for 0.10.12 release
          * due to downmixing failure.
          * See Bug #608892 for more details */
--- patch-mp3 ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: