ports/181248: [PATCH] print/cups-base Disable INSTALLS_ICONS for non-X11

[Derek Kulinski]

The following reply was made to PR ports/181248; it has been noted by GNATS.

From: Derek Kulinski <takeda at takeda.tk>
To: bug-followup at FreeBSD.org, john.marshall at riverwillow.com.au
Cc:  
Subject: Re: ports/181248: [PATCH] print/cups-base Disable INSTALLS_ICONS for non-X11
Date: Tue, 20 Aug 2013 18:42:31 -0700

 Thanks John, for the fix I noticed it when I tried to update cups and
 portmaster showed me a huge list of ports that it'll install.
 
 I too would like to have this patch included, though I'm wondering if
 there was a reason not moving INSTALLS_ICONS in XDG_OPEN block as
 follows: 
 
 .if !defined(CUPS_CLIENT) && !defined(CUPS_IMAGE) && ${PORT_OPTIONS:MXDG_OPEN}
 RUN_DEPENDS+=           xdg-open:${PORTSDIR}/devel/xdg-utils
 INSTALLS_ICONS=true
 .endif
 
 As I understand this the part which adds X11 dependency, and as I
 understand WITHOUT_X11 is a legacy option.
 It also possibly fixes what commit 324428 was trying to fix, which is
 to make sure that this variable should be only defined for the
 cups-base.
 
 Best regards,
 Derek