ports/171542: [PATCH] multimedia/x264: Remove PGO as default OPTION (breaks with CLANG)

[Kubilay Kocak]

>Number:         171542
>Category:       ports
>Synopsis:       [PATCH] multimedia/x264: Remove PGO as default OPTION (breaks with CLANG)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 11 14:10:04 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Kubilay Kocak
>Release:        FreeBSD 9.0-RELEASE-p3 amd64
>Organization:
>Environment:
System: FreeBSD freebsd-9-amd64 9.0-RELEASE-p3 FreeBSD 9.0-RELEASE-p3 #0: Sat Jul  7 21:26:56 EST
>Description:
- Remove PGO from OPTIONS_DEFAULT

This options switches the ALL_TARGET to fprofiles, and adds "-fprofile-generate" to LDFLAGS.

Clang requires libprofile_rt.a for this, but it doesnt not exist in 9.0 (at least)

The following is the linker error:

/usr/local/bin/ld: cannot find /usr/bin/../lib/libprofile_rt.a: No such file or directory
Port maintainer (mm at FreeBSD.org) is cc'd.

==[QA]==

1) Redports without PGO and ASM: https://redports.org/buildarchive/20120911132551-27180/
2) Redports without PGO only: https://redports.org/buildarchive/20120911133440-20261/

Note: CLANG/i386 build failure in redports (2) above is due to underlying binutils dependency.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:

--- x264-0.125.2201.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/multimedia/x264/Makefile ./Makefile
--- /usr/ports/multimedia/x264/Makefile	2012-08-08 02:37:31.000000000 +1000
+++ ./Makefile	2012-09-11 23:34:05.000000000 +1000
@@ -38,7 +38,7 @@
 MAKE_JOBS_SAFE=	yes
 
 OPTIONS_DEFINE=	ASM DEBUG PGO GCC44 GPAC X11_OUTPUT
-OPTIONS_DEFAULT=	ASM PGO GPAC
+OPTIONS_DEFAULT=	ASM GPAC
 ASM_DESC=		Assembly optimizations (devel/binutils)
 GCC44_DESC=		Use gcc 4.4+ (implies WITH_ASM)
 GPAC_DESC=		Enable MPEG-4 Output
--- x264-0.125.2201.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: