ports/173213: [PATCH] net-mgmt/net-snmp: fix embedded perl support

[Frank Wall]

>Number:         173213
>Category:       ports
>Synopsis:       [PATCH] net-mgmt/net-snmp: fix embedded perl support
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 30 13:30:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Frank Wall
>Release:        7.4-RELEASE-p9
>Organization:
>Environment:
FreeBSD boron 7.4-RELEASE-p9 FreeBSD 7.4-RELEASE-p9 #0: Mon Jun 11 19:47:58 UTC 2012     root at amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
Support for embedded perl was broken by svn commit: r305803. It is impossible to enable support for embedded perl as of now.
>How-To-Repeat:
- try to enable embedded perl in net-mgmt/net-snmp: make config
- verify that it has been enabled: 

grep PERL_EMBEDDED /var/db/ports/net-snmp/options
_FILE_COMPLETE_OPTIONS_LIST=AX_SOCKONLY DMALLOC DUMMY IPV6 MFD_REWRITES MYSQL PERL PERL_EMBEDDED PYTHON TKMIB UNPRIVILEGED
OPTIONS_FILE_SET+=PERL_EMBEDDED

- try to run the configure script: make configure
- you will notice that embedded perl support is still DISABLED:

---------------------------------------------------------
            Net-SNMP configuration summary:
---------------------------------------------------------

  SNMP Versions Supported:    1 2c 3
  Building for:               freebsd7
  Net-SNMP Version:           5.7.2
  Network transport support:  Callback Unix Alias TCP UDP IPv4Base SocketBase TCPBase UDPIPv4Base UDPBase
  SNMPv3 Security Modules:     usm
  Agent MIB code:             host disman/event-mib smux mibII/mta_sendmail mibII/tcpTable ucd-snmp/diskio sctp-mib default_modules =>  host/hrh_storage host/hrh_filesys host/hrSWInstalledTable host/hrSWRunTable host/hr_system host/hr_device host/hr_other host/hr_proc host/hr_network host/hr_print host/hr_disk host/hr_partition disman/event smux/smux mibII/ip util_funcs/header_simple_table sctp-mib/sctpScalars sctp-mib/sctpTables snmpv3mibs mibII ucd_snmp notification notification-log-mib target agent_mibs agentx disman/event disman/schedule utilities host
  MYSQL Trap Logging:         unavailable
  Embedded Perl support:      disabled
  SNMP Perl modules:          building -- not embeddable
  SNMP Python modules:        disabled
  Crypto support from:        crypto
  Authentication support:     MD5 SHA1
  Encryption support:         DES AES
  Local DNSSEC validation:    disabled

---------------------------------------------------------

- result: support for embedded perl is disabled
- expected result: embedded perl should be enabled
>Fix:
apply the patch, fix the relevant port OPTION

Patch attached with submission follows:

--- net-mgmt/net-snmp/Makefile.orig	2012-10-13 03:07:32.000000000 +0200
+++ net-mgmt/net-snmp/Makefile	2012-10-30 14:16:17.000000000 +0100
@@ -99,12 +99,12 @@
 .if ${PORT_OPTIONS:MPERL}
 USE_PERL5=	yes
 CONFIGURE_ARGS+=--with-perl-modules
-.if empty(${PORT_OPTIONS:MPERL_EMBEDDED})
-CONFIGURE_ARGS+=--disable-embedded-perl
-PLIST_SUB+=	WITH_PERL_EMBEDDED="@comment "
-.else
+.if ${PORT_OPTIONS:MPERL_EMBEDDED}
 CONFIGURE_ARGS+=--enable-embedded-perl
 PLIST_SUB+=	WITH_PERL_EMBEDDED=""
+.else
+CONFIGURE_ARGS+=--disable-embedded-perl
+PLIST_SUB+=	WITH_PERL_EMBEDDED="@comment "
 .endif
 PLIST_SUB+=	WITH_PERL=""
 .else


>Release-Note:
>Audit-Trail:
>Unformatted: