ports/172777: New port: net/libnfs a client library for accessing NFS shares

[Raphael Kubo da Costa]

The following reply was made to PR ports/172777; it has been noted by GNATS.

From: Raphael Kubo da Costa <rakuco at FreeBSD.org>
To: bug-followup at FreeBSD.org
Cc: Manuel Creach <manuel.creach at icloud.com>
Subject: Re: ports/172777: New port: net/libnfs a client library for accessing NFS shares
Date: Sun, 21 Oct 2012 16:34:59 +0300

 A few comments after looking at the Makefile:
 
  o It would be good if you could adapt the header comments to the new
    format.
 
  o Setting PORTREVISION to 1 (and in that location) is wrong, since this
    is a new port. I suggest running `portlint' to look for this kind of
    issue.
 
  o Try using USE_GITHUB and its related variables so you do not need to
    hardcode the whole MASTER_SITES address.
 
  o You probably need not override FETCH_ARGS.
 
  o The port itself already seems to always set _FILE_OFFSET_BITS to 64,
    so the CFLAGS addition is redundant.
 
  o The port does not list any build dependency except for the autotools
    stuff, so I wonder if changing LDFLAGS is really necessary.
 
  o Still on the same subject, are you sure you need to change
    ACLOCAL_ARGS and and AUTOMAKE_ARGS?