ports/171951: update port: security/fwknop FireWall KNock OPerator
Raphael Kubo da Costa
rakuco at FreeBSD.org
Sun Oct 21 11:30:01 UTC 2012
The following reply was made to PR ports/171951; it has been noted by GNATS.
From: Raphael Kubo da Costa <rakuco at FreeBSD.org>
To: bug-followup at FreeBSD.org
Cc: Sean Greven <sean.greven at gmail.com>
Subject: Re: ports/171951: update port: security/fwknop FireWall KNock OPerator
Date: Sun, 21 Oct 2012 14:24:13 +0300
A few comments about the patch:
o You have added fwknopd.in, but don't seem to use or install it. Plus,
shouldn't you preprocess it instead of hardcoding the installation
paths?
o IIRC ports normally do not install info/dir, as it can cause
conflicts.
o Instead of specifying info/libfko.info in the plist, you could use
the INFO variable in the Makefile.
More information about the freebsd-ports-bugs
mailing list