ports/172426: [PATCH] security/libpreludedb: Converting port to new options framework

[Michael Gmelin]

The following reply was made to PR ports/172426; it has been noted by GNATS.

From: Michael Gmelin <freebsd at grem.de>
To: Eitan Adler <lists at eitanadler.com>
Cc: bug-followup at freebsd.org
Subject: Re: ports/172426: [PATCH] security/libpreludedb: Converting port to
 new options framework
Date: Sun, 7 Oct 2012 06:56:24 +0200

 On Sun, 7 Oct 2012 00:46:28 -0400
 Eitan Adler <lists at eitanadler.com> wrote:
 
 > On 7 October 2012 00:15, Michael Gmelin <freebsd at grem.de> wrote:
 > > patch -p0 -E </path/to/patchfile
 > 
 > For some reason this shows up as a 'reversed patch' for me. I use svn
 > apply patch
 > 
 > > +OPTIONS_DEFINE=        DOCS MYSQL PERL PGSQL PYTHON SQLITE
 > > +OPTIONS_DEFAULT=MYSQL
 > > +PERL_DESC=     Include Perl bindings
 > > +PYTHON_DESC=   Include Python bindings
 > > +MYSQL_DESC=    Use MySQL backend
 > > +PGSQL_DESC=    Use PostgreSQL backend
 > > +SQLITE_DESC=   Use SQLite backend
 > 
 I set them intentionally, since by using the defaults the user has no
 chance to really understand what's meant, in this case it would say:
 
 PERL Perl scripting language
 (like how, will it install perl, is it a plugin, a language binding?)
 
 PYTHON would be ok (says Python bindings)
 
 MYSQL says MySQL database - again, how does it connect to the port, is
 it a backend? Probably, but not user friendly, same for PGSQL and
 SQLite. Just stating "SQLite database" as a configuration option
 doesn't really cut it (IMHO)
 
 Why not a MySQL binding and a Perl backend, or using Python as a data
 store (not as bizarr as it might sound at first)
 
 > None of these were needed as they were in Mk/bsd.options.desc.mk
 > easy way to test:  try 'make showconfig' before setting them
 
 That's what I did and decided that the user would loose
 useful information that way.
 
 Cheers,
 Michael
 
 
 > 
 > >  post-install:
 > > -.if !defined(NOPORTDOCS)
 
 oops
 
 > 
 > missed one of these.
 > 
 > committed though, thanks!
 > 
 
 
 
 
 
 -- 
 Michael Gmelin