ports/168339: [patch] sysutils/userspace-rcu update to 0.7.2

[Leo Vandewoestijne]

The following reply was made to PR ports/168339; it has been noted by GNATS.

From: Leo Vandewoestijne <freebsd at dns-lab.com.unicycle.net>
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: ports/168339: [patch] sysutils/userspace-rcu update to 0.7.2
Date: Sat, 26 May 2012 13:08:04 +0000

 Hi Hirohisa Yamaguchi,
 
 Thanks again for your update and working out all the patching.
 But as I found the patching quite intensive, I asked for advice:
 
 > * Leo Vandewoestijne wrote:
 > > Hello Mathieu Desnoyers,
 > >
 > >
 > > I'm Leo Vandewoestijne, port maintainer for Userspace RCU in FreeBSD.
 > >
 > > Version 0.7.2 was released yesterday, and today the new FreeBSD port for it was submitted.
 > > It however got a LOT of patching, and I'm not 100% sure if that doesn't break anything,
 > > while this of course is important, as urcu is a dependancy for the knot-dns nameserver.
 > >
 > > Although a lot, it -to me- seems OK, and I tested it with succes.
 > > But could you please have a look at this contribution of Hirohisa Yamaguchi:
 > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/168339
 > > (the 2nd patch that is), and please give us your feedback?
 > >
 > > Thanks in advance,
 > 
 > Hi Leo,
 > 
 > Thanks for getting in touch with me. I would indeed prefer to get the
 > patch upstream and do a new patchlevel release (e.g. 0.7.3) if any
 > change is needed to support FreeBSD. e.g., the change to
 > rculfhash-mm-mmap.c should to submitted upstream.
 >
 > Looking at the patch in the URL you provided, I don't know why the
 > changes to the test programs are required ? Any issue with bash (use of
 > jot instead of seq) ? Also, use of "sysctl -n kern.smp.cpus" does not
 > seem to work on Linux, so finding more portable way to query this might
 > be good if testing on the actual number of CPUs is really required.
 >
 > Of course, the Makefile that contains BSD-specific info, and pkg-list
 > should probably be added in the freebsd-specific package.
 > 
 > So please ask the person who provided the patch if he can send me the
 > changes that are required, and if other changes are just cosmetic, and
 > not really needed, I would recommend against putting them in the
 > package. Any difference from upstream that is not required will be a
 > burden on you, the package manager.
 >
 > Thanks!
 > 
 >
 > Mathieu
 
 
 So, -to me- the jot/seq issue is clear, and I prefer patching better than making bash a dependency,
 although there's maybe a better way to address it?
 
 Also the "sysctl -n kern.smp.cpus" would be safe in FreeBSD, but in deed might be done more portable?
 
 The NR_READERS makes sense to me, but yes, in overal this is a lot of work to repeat at each new release.
 As they (since 0.7.0) try to support OpenBSD, NetBSD and Darwin it seems they prefer portability anyway
 (and I expect those could also benefit of your adjustments).
 
 So maybe you can get in in touch with the project for the mentioned 0.7.3 ..? That would be nice!
 
 
 As you probably know already Mathieu can be reached at mathieu.desnoyers at efficios.com 
 
 
 -- 
 
 Met vriendelijke groet,
 With kind regards,
 
 
 Leo Vandewoestijne