ports/168214: Heimdal 1.5.2 port is broken if BDB chosen as backend

[Robert Simmons]

>Number:         168214
>Category:       ports
>Synopsis:       Heimdal 1.5.2 port is broken if BDB chosen as backend
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 22 04:50:01 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Robert Simmons
>Release:        9.0-RELEASE
>Organization:
>Environment:
>Description:
The version of Heimdal in ports (1.5.2) is broken if you try to build it with BDB as backend support.

If you set it to not use BDB, it still detects the BDB version in the base FreeBSD OS.  This version of Heimdal is incompatible with the version of BDB in the base OS, and this leads to an unusable port in all configurations.  This is due to the Makefile using an older configure switch that is no longer valid.

A second problem is that if you set it to use BDB as the backend, the port is unable to find the version of BDB installed through dependencies.  This is due to another mistake in the Makefile.

A third problem is due to the incompatibility with the OS's BDB, if you leave the port configured as default it is unusable.  I have corrected this by setting BDB to on as the default.  This leaves a usable port if installed with default configure settings.
>How-To-Repeat:
Try to install and use this port.
>Fix:
I have included a patch that fixes all three problems that I have listed.  Additionally, it removes a dead mirror from the list of mirrors.

Patch attached with submission follows:

--- ports/security/heimdal/Makefile.old	2012-05-20 16:19:39.000000000 -0400
+++ ports/security/heimdal/Makefile	2012-05-20 16:21:43.000000000 -0400
@@ -7,13 +7,12 @@
 
 PORTNAME=	heimdal
 PORTVERSION=	1.5.2
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	security ipv6
 MASTER_SITES=	http://www.h5l.org/dist/src/ \
 		http://ftp.pdc.kth.se/pub/heimdal/src/ \
 		ftp://ftp.pdc.kth.se/pub/heimdal/src/ \
-		ftp://ftp.sunet.se/pub/unix/admin/mirror-pdc/heimdal/src/ \
-		ftp://ftp.ayamura.org/pub/heimdal/
+		ftp://ftp.sunet.se/pub/unix/admin/mirror-pdc/heimdal/src/
 
 MAINTAINER=	Joerg.Pulz at frm2.tum.de
 COMMENT=	A popular BSD-licensed implementation of Kerberos 5
@@ -22,7 +21,7 @@
 
 OPTIONS=	IPV6	"Enable IPV6 support"				on \
 		KCM	"Enable Kerberos Credentials Manager"		on \
-		BDB	"Enable BerkeleyDB KDC backend support"		off \
+		BDB	"Enable BerkeleyDB KDC backend support"		on \
 		SQLITE	"Enable SQLite KDC backend support"		off \
 		LDAP	"Enable OpenLDAP KDC backend support"		off \
 		PKINIT	"Enable PK-INIT support"			on \
@@ -78,9 +77,9 @@
 CPPFLAGS+=	-I${BDB_INCLUDE_DIR}
 LDFLAGS+=	-L${BDB_LIB_DIR}
 CONFIGURE_ARGS+=	--with-berkeley-db=${LOCALBASE}
-#			--with-berkeley-db-include=${BDB_INCLUDE_DIR}
+			--with-berkeley-db-include=${BDB_INCLUDE_DIR}
 .else
-CONFIGURE_ARGS+=	--without-berkeley-db
+CONFIGURE_ARGS+=	--with-berkeley-db=no
 .endif
 
 .if defined(WITH_SQLITE)


>Release-Note:
>Audit-Trail:
>Unformatted: