ports/167843: devel/simgear 2.6.0_1 build fails due to missing include path

[Oleksii]

>Number:         167843
>Category:       ports
>Synopsis:       devel/simgear 2.6.0_1 build fails due to missing include path
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 13 19:50:02 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Oleksii
>Release:        9.0-RELEASE-p1
>Organization:
>Environment:
FreeBSD zirco.compal.nb 9.0-RELEASE-p1 FreeBSD 9.0-RELEASE-p1 #2: Mon May  7 20:37:35 UTC 2012     oleksii at zirco.compal.nb:/usr/obj/usr/src/sys/COMPAL  i386
>Description:
The compilation devel/simgear (version 2.6.0_1) fails with multiple errors. The reason for this is, according to my analysis, missing include path. Many includes are written as following:

#include <sigmear/io/raw_socket.hxx>

, whereas simgear directory is not specified as an include path, i.e. no corresponding -I flag is issued to the compiler. simgear directory is located in source top directory.

>How-To-Repeat:
# cd /usr/ports/devel/simgear
# make
>Fix:
Solved by making CMake pass simgear directory to the include paths. Modified SimGearComponent.cmake file to eliminate code duplication, because it is used by several modules that failed to compile.


--- SimGearComponent.cmake      2012-05-13 22:21:59.000000000 +0000
+++ SimGearComponent.cmake.new  2012-05-13 22:23:37.000000000 +0000
@@ -1,4 +1,6 @@
 
+include_directories(BEFORE ${PROJECT_SOURCE_DIR})
+
 macro(simgear_component_common name includePath sourcesList sources headers)
     if (SIMGEAR_SHARED)


Patch attached with submission follows:

--- SimGearComponent.cmake	2012-05-13 22:21:59.000000000 +0000
+++ SimGearComponent.cmake.new	2012-05-13 22:23:37.000000000 +0000
@@ -1,4 +1,6 @@
 
+include_directories(BEFORE ${PROJECT_SOURCE_DIR})
+
 macro(simgear_component_common name includePath sourcesList sources headers)
     if (SIMGEAR_SHARED)
 


>Release-Note:
>Audit-Trail:
>Unformatted: