ports/167368: Python version propagation breaks USE_PYTHON= usage for dependency builds
Marcus von Appen
mva at FreeBSD.org
Sun May 6 17:20:15 UTC 2012
The following reply was made to PR ports/167368; it has been noted by GNATS.
From: Marcus von Appen <mva at FreeBSD.org>
To: FreeBSD-gnats-submit at freebsd.org, freebsd-ports-bugs at FreeBSD.org
Cc: freebsd-ports at freebsd.org, python at freebsd.org
Subject: Re: ports/167368: Python version propagation breaks USE_PYTHON=
usage for dependency builds
Date: Sun, 6 May 2012 19:07:11 +0200
--OROCMA9jn6tkzFBc
Content-Type: multipart/mixed; boundary="PuGuTyElPB9bOcsM"
Content-Disposition: inline
--PuGuTyElPB9bOcsM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In 2003 we introduced DEPENDS_ARGS to enforce the python version on
dependencies[0].
In 2005 we introduced th .MAKEFLAGS propagation to work around an issue
for Zope[1].
I doubt that both are still valid after we allowed parallel python
versions for quite some while now. In any case, the current
implementation _breaks_ ports, if they have non-matching sets of
supported python versions.
The attached patch removes both entries and a local tinderbox run did
not reveal any problems. However, the problem described here does
usually _not_ occur in a tinderbox, since every port is treated as a
single item, instead of a typical user workflow.
Thus more testing (especially with zope-related ports) is highly
appreciated.
[0] http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.python.mk?annotate=1.41
[1] http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.python.mk?annotate=1.62
Regards
Marcus
--PuGuTyElPB9bOcsM
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="bsd.python.mk.patch"
Content-Transfer-Encoding: quoted-printable
Index: Mk/bsd.python.mk
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/pcvs/ports/Mk/bsd.python.mk,v
retrieving revision 1.143
diff -u -r1.143 bsd.python.mk
--- Mk/bsd.python.mk 11 Apr 2012 12:52:16 -0000 1.143
+++ Mk/bsd.python.mk 6 May 2012 17:01:48 -0000
@@ -339,7 +339,6 @@
PYTHONBASE!=3D (${PYTHON_CMD} -c 'import sys; print sys.prefix' \
2> /dev/null || ${ECHO_CMD} ${LOCALBASE}) | ${TAIL} -1
.endif
-DEPENDS_ARGS+=3D PYTHON_VERSION=3D${PYTHON_VERSION}
=20
# We can only use the cached version if we are using the default python ve=
rsion. Otherwise it
# should point to some other version we have installed, according to the p=
ort USE_PYTHON
@@ -354,9 +353,6 @@
PYTHON_PORTVERSION=3D ${PYTHON_DEFAULT_PORTVERSION}
.endif
=20
-# Propagate the chosen python version to submakes.
-.MAKEFLAGS: PYTHON_VERSION=3Dpython${_PYTHON_VERSION}
-
# Python-3.2
.if ${PYTHON_VERSION} =3D=3D "python3.2"
PYTHON_PORTVERSION?=3D3.2.3
--PuGuTyElPB9bOcsM--
--OROCMA9jn6tkzFBc
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAk+mr78ACgkQi68/ErJnpkfXfQCfd/oAr457Rcohe4ai6+yu4ySi
OOMAnihREOWnftpVzffjzz/a9cGAAN0R
=HINZ
-----END PGP SIGNATURE-----
--OROCMA9jn6tkzFBc--
More information about the freebsd-ports-bugs
mailing list