ports/165851: portlint -- warn about being too specific with shlib versions

[Matthew Seaman]

>Number:         165851
>Category:       ports
>Synopsis:       portlint -- warn about being too specific with shlib versions
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 08 09:10:12 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Matthew Seaman
>Release:        FreeBSD 9.0-STABLE amd64
>Organization:
>Environment:
System: FreeBSD lucid-nonsense.infracaninophile.co.uk 9.0-STABLE FreeBSD 9.0-STABLE #7 r232650: Wed Mar 7 12:37:12 GMT 2012 root at lucid-nonsense.infracaninophile.co.uk:/usr/obj/usr/src/sys/LUCID-NONSENSE amd64


	
>Description:

After various discussions on freebsd-ports at ... here is a patch to add
a warning when shared libraries are specified with a version number in
LIB_DEPEND lines. Consensus is no ABI version should be specified
unless it is known that certain ABI versions do not work.

>How-To-Repeat:
	
>Fix:

	

--- portlint.diff begins here ---
Index: src/portlint.pl
===================================================================
RCS file: /home/ncvs/ports/ports-mgmt/portlint/src/portlint.pl,v
retrieving revision 1.125
diff -u -u -r1.125 portlint.pl
--- src/portlint.pl	27 Dec 2011 01:26:34 -0000	1.125
+++ src/portlint.pl	18 Feb 2012 10:08:27 -0000
@@ -1330,6 +1330,13 @@
 					"found in \${PORTSDIR}/Mk/bsd.apache.mk.");
 			}
 
+			# Check for over-specific shared library dependencies
+			if ( $j eq 'LIB_DEPENDS' && $m{'dep'} =~ m/(\.\d+$)/ ) {
+				&perror("WARN", $file, -1, "$j don't specify the " .
+					"ABI version number $1 in $m{dep} unless it is " .
+					"really necessary.");
+			}
+
 			# check port dir existence
 			$k = $m{'dir'};
 			$k =~ s/\${PORTSDIR}/$ENV{'PORTSDIR'}/;
--- portlint.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: