ports/165623: Mk/bsd.comands.mk et al -- conflicting uses of ${FILE}

Chris Rees utisoft at gmail.com
Sat Mar 3 13:00:30 UTC 2012


The following reply was made to PR ports/165623; it has been noted by GNATS.

From: Chris Rees <utisoft at gmail.com>
To: Matthew Seaman <m.seaman at infracaninophile.co.uk>
Cc: "bug-followup at freebsd.org" <bug-followup at freebsd.org>
Subject: Re: ports/165623: Mk/bsd.comands.mk et al -- conflicting uses of ${FILE}
Date: Sat, 3 Mar 2012 12:56:27 +0000

 --14dae9340a8fab5d8904ba56388f
 Content-Type: text/plain; charset=ISO-8859-1
 
 On 2 Mar 2012 23:37, "Matthew Seaman" <m.seaman at infracaninophile.co.uk>
 wrote:
 >
 > On 02/03/2012 21:20, Michael Scheidell wrote:
 > >  does portlint need to be upgraded to tell you to use ${FILE_CMD}
 instead
 > >  of ${FILE} ?
 >
 > Perhaps, but that's going to annoy the vast majority of people that use
 > ${FILE} to mean something other than the file(1) application.  I tend
 > towards the view that there's so much prior art, and that saying:
 >
 > .for FILE in ${LIST_OF_FILES}
 > ...
 > .endfor
 >
 > is so natural a construct that trying to make people do it differently
 > would be wildly unpopular.
 >
 
 Or we could put the portlint check in, and people who don't want to see it
 complain could use lowers for loop vars.
 
 Sorry to go on about this, but it's very important to differentiate,
 considering that their behaviour is very different from regular variables.
 
 Note that I withdraw my objection to FILE_CMD as per pointers from others :)
 
 Chris
 
 --14dae9340a8fab5d8904ba56388f
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 <p><br>
 On 2 Mar 2012 23:37, "Matthew Seaman" <<a href=3D"mailto:m.sea=
 man at infracaninophile.co.uk">m.seaman at infracaninophile.co.uk</a>> wrote:<=
 br>
 ><br>
 > On 02/03/2012 21:20, Michael Scheidell wrote:<br>
 > > =A0does portlint need to be upgraded to tell you to use ${FILE_CM=
 D} instead<br>
 > > =A0of ${FILE} ?<br>
 ><br>
 > Perhaps, but that's going to annoy the vast majority of people tha=
 t use<br>
 > ${FILE} to mean something other than the file(1) application. =A0I ten=
 d<br>
 > towards the view that there's so much prior art, and that saying:<=
 br>
 ><br>
 > .for FILE in ${LIST_OF_FILES}<br>
 > ...<br>
 > .endfor<br>
 ><br>
 > is so natural a construct that trying to make people do it differently=
 <br>
 > would be wildly unpopular.<br>
 ></p>
 <p>Or we could put the portlint check in, and people who don't want to =
 see it complain could use lowers for loop vars.</p>
 <p>Sorry to go on about this, but it's very important to differentiate,=
  considering that their behaviour is very different from regular variables.=
 </p>
 <p>Note that I withdraw my objection to FILE_CMD as per pointers from other=
 s :)</p>
 <p>Chris</p>
 
 --14dae9340a8fab5d8904ba56388f--



More information about the freebsd-ports-bugs mailing list