ports/164177: audio/squeezeboxserver should require mysql 5.0 server rather than just mysql server

Thu Jun 21 12:20:13 UTC 2012

The following reply was made to PR ports/164177; it has been noted by GNATS.

From: <the_mix_room at hotmail.com>
To: <bug-followup at freebsd.org>
Cc: <danno at umich.edu>
Subject: Re: ports/164177: audio/squeezeboxserver should require mysql 5.0
 server rather than just mysql server
Date: Thu, 21 Jun 2012 12:15:14 +0000

 --_4281e75e-976c-4a2f-bdf1-085368573516_
 Content-Type: multipart/alternative;
 	boundary="_e0800c8b-3df2-402b-9d8c-a49e6c8795d3_"

 --_e0800c8b-3df2-402b-9d8c-a49e6c8795d3_
 Content-Type: text/plain; charset="iso-8859-2"
 Content-Transfer-Encoding: quoted-printable

 I have patched the Makefile to make the necessary adjustments so that squee=
 zeboxserver can be installed and run. =20

 The problem is that with the introduction of MySQL 5.5 some commands are no=
  longer available. They have been replaced by equivalents.=20
 http://dev.mysql.com/doc/refman/5.5/en/server-options.html#option_mysqld_sk=
 ip-external-locking as an example.=20

 The commands are taken from: http://permalink.gmane.org/gmane.music.equipme=
 nt.slimdevices.squeezecenter/26896

 I believe applying the patch below is the simplest until upstream gets fixe=
 d. Would be good if this relatively simple patch could be committed.=20

 --- Makefile    2012-06-21 14:08:40.000000000 +0200
 +++ Makefile.new    2012-06-21 13:58:08.000000000 +0200
 @@ -57=2C7 +57=2C6 @@
  .endif
 =20
  USE_MYSQL=3D    server
 -WANT_MYSQL_VER=3D50
 =20
  .if ${PORT_OPTIONS:MAPE}
  RUN_DEPENDS+=3D    mac:${PORTSDIR}/audio/mac
 @@ -173=2C6 +172=2C12 @@
          -e 's|%%TMP_SLIMDIR%%|${TMP_SLIMDIR}|g' \
          ${WRKSRC}/scanner.pl \
          ${WRKSRC}/slimserver.pl
 +    sed -i '.bak' \
 +        -e 's/skip-locking/skip-external-locking/' \
 +        -e 's/default-character-set/character-set-server/'\
 +        -e 's/default-collation/collation-server/'  ${WRKSRC}/MySQL/my.tt=
 =20
 +    sed -i '.bak' \
 +        -e 's/TYPE=3DInnoDB/ENGINE=3DInnoDB/' ${WRKSRC}/SQL/mysql/schema_*=
 .sql
 =20
  do-build:
      @${MKDIR} -m 0755 ${TMP_SLIMDIR}

  		 	   		  =

 --_e0800c8b-3df2-402b-9d8c-a49e6c8795d3_
 Content-Type: text/html; charset="iso-8859-2"
 Content-Transfer-Encoding: quoted-printable

 <html>
 <head>
 <style><!--
 .hmmessage P
 {
 margin:0px=3B
 padding:0px
 }
 body.hmmessage
 {
 font-size: 10pt=3B
 font-family:Tahoma
 }
 --></style></head>
 <body class=3D'hmmessage'><div dir=3D'ltr'>
 I have patched the Makefile to make the necessary adjustments so that squee=
 zeboxserver can be installed and run.&nbsp=3B <br><br>The problem is that w=
 ith the introduction of MySQL 5.5 some commands are no longer available. Th=
 ey have been replaced by equivalents. <br>http://dev.mysql.com/doc/refman/5=
 .5/en/server-options.html#option_mysqld_skip-external-locking as an example=
 . <br><br>The commands are taken from: <a href=3D"http://permalink.gmane.or=
 g/gmane.music.equipment.slimdevices.">http://permalink.gmane.org/gmane.musi=
 c.equipment.slimdevices.</a><a href=3D"http://www.freebsd.org/cgi/query-pr.=
 cgi?pr=3D26896&amp=3Bcat=3Dsqueezecenter">squeezecenter/26896</a><br><br>I =
 believe applying the patch below is the simplest until upstream gets fixed.=
  Would be good if this relatively simple patch could be committed. <br><br>=
 --- Makefile&nbsp=3B&nbsp=3B&nbsp=3B 2012-06-21 14:08:40.000000000 +0200<br=
 >+++ Makefile.new&nbsp=3B&nbsp=3B&nbsp=3B 2012-06-21 13:58:08.000000000 +02=
 00<br>@@ -57=2C7 +57=2C6 @@<br>&nbsp=3B.endif<br>&nbsp=3B<br>&nbsp=3BUSE_MY=
 SQL=3D&nbsp=3B&nbsp=3B&nbsp=3B server<br>-WANT_MYSQL_VER=3D50<br>&nbsp=3B<b=
 r>&nbsp=3B.if ${PORT_OPTIONS:MAPE}<br>&nbsp=3BRUN_DEPENDS+=3D&nbsp=3B&nbsp=
 =3B&nbsp=3B mac:${PORTSDIR}/audio/mac<br>@@ -173=2C6 +172=2C12 @@<br>&nbsp=
 =3B&nbsp=3B&nbsp=3B&nbsp=3B &nbsp=3B&nbsp=3B&nbsp=3B -e 's|%%TMP_SLIMDIR%%|=
 ${TMP_SLIMDIR}|g' \<br>&nbsp=3B&nbsp=3B&nbsp=3B&nbsp=3B &nbsp=3B&nbsp=3B&nb=
 sp=3B ${WRKSRC}/scanner.pl \<br>&nbsp=3B&nbsp=3B&nbsp=3B&nbsp=3B &nbsp=3B&n=
 bsp=3B&nbsp=3B ${WRKSRC}/slimserver.pl<br>+&nbsp=3B&nbsp=3B&nbsp=3B sed -i =
 '.bak' \<br>+&nbsp=3B&nbsp=3B&nbsp=3B &nbsp=3B&nbsp=3B&nbsp=3B -e 's/skip-l=
 ocking/skip-external-locking/' \<br>+&nbsp=3B&nbsp=3B&nbsp=3B &nbsp=3B&nbsp=
 =3B&nbsp=3B -e 's/default-character-set/character-set-server/'\<br>+&nbsp=
 =3B&nbsp=3B&nbsp=3B &nbsp=3B&nbsp=3B&nbsp=3B -e 's/default-collation/collat=
 ion-server/'&nbsp=3B ${WRKSRC}/MySQL/my.tt <br>+&nbsp=3B&nbsp=3B&nbsp=3B se=
 d -i '.bak' \<br>+&nbsp=3B&nbsp=3B&nbsp=3B &nbsp=3B&nbsp=3B&nbsp=3B -e 's/T=
 YPE=3DInnoDB/ENGINE=3DInnoDB/' ${WRKSRC}/SQL/mysql/schema_*.sql<br>&nbsp=3B=
 <br>&nbsp=3Bdo-build:<br>&nbsp=3B&nbsp=3B&nbsp=3B&nbsp=3B @${MKDIR} -m 0755=
  ${TMP_SLIMDIR}<br><br> 		 	   		  </div></body>
 </html>=

 --_e0800c8b-3df2-402b-9d8c-a49e6c8795d3_--

 --_4281e75e-976c-4a2f-bdf1-085368573516_
 Content-Type: application/octet-stream
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment; filename="patch_squeezeboxserver_Makefile"

 LS0tIE1ha2VmaWxlCTIwMTItMDYtMjEgMTQ6MDg6NDAuMDAwMDAwMDAwICswMjAwCisrKyBNYWtl
 ZmlsZS5uZXcJMjAxMi0wNi0yMSAxMzo1ODowOC4wMDAwMDAwMDAgKzAyMDAKQEAgLTU3LDcgKzU3
 LDYgQEAKIC5lbmRpZgogCiBVU0VfTVlTUUw9CXNlcnZlcgotV0FOVF9NWVNRTF9WRVI9NTAKIAog
 LmlmICR7UE9SVF9PUFRJT05TOk1BUEV9CiBSVU5fREVQRU5EUys9CW1hYzoke1BPUlRTRElSfS9h
 dWRpby9tYWMKQEAgLTE3Myw2ICsxNzIsMTIgQEAKIAkgICAgLWUgJ3N8JSVUTVBfU0xJTURJUiUl
 fCR7VE1QX1NMSU1ESVJ9fGcnIFwKIAkJJHtXUktTUkN9L3NjYW5uZXIucGwgXAogCQkke1dSS1NS
 Q30vc2xpbXNlcnZlci5wbAorCXNlZCAtaSAnLmJhaycgXAorCQktZSAncy9za2lwLWxvY2tpbmcv
 c2tpcC1leHRlcm5hbC1sb2NraW5nLycgXAorCQktZSAncy9kZWZhdWx0LWNoYXJhY3Rlci1zZXQv
 Y2hhcmFjdGVyLXNldC1zZXJ2ZXIvJ1wKKwkJLWUgJ3MvZGVmYXVsdC1jb2xsYXRpb24vY29sbGF0
 aW9uLXNlcnZlci8nICAke1dSS1NSQ30vTXlTUUwvbXkudHQgCisJc2VkIC1pICcuYmFrJyBcCisJ
 CS1lICdzL1RZUEU9SW5ub0RCL0VOR0lORT1Jbm5vREIvJyAke1dSS1NSQ30vU1FML215c3FsL3Nj
 aGVtYV8qLnNxbAogCiBkby1idWlsZDoKIAlAJHtNS0RJUn0gLW0gMDc1NSAke1RNUF9TTElNRElS
 fQo=

 --_4281e75e-976c-4a2f-bdf1-085368573516_--