ports/169220: [PATCH] sysutils/cciss_vol_status: fix usage of ${SRC_BASE} before it is defined

Jason Helfman jgh at FreeBSD.org
Mon Jun 18 23:40:23 UTC 2012


>Number:         169220
>Category:       ports
>Synopsis:       [PATCH] sysutils/cciss_vol_status: fix usage of ${SRC_BASE} before it is defined
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 18 23:40:22 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Jason Helfman
>Release:        FreeBSD 8.3-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr  9 21:23:18 UTC
>Description:
Original PR filed as ports/165994

SRC_BASE is being used before being defined in several ports. it happened to
work anyways in most cases because the main use of SRC_BASE is for checking if
${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just
checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/.

Port maintainer (mm at FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- cciss_vol_status-1.09.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/sysutils/cciss_vol_status/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile	23 Mar 2011 15:53:21 -0000	1.7
+++ Makefile	18 Jun 2012 23:36:52 -0000
@@ -21,8 +21,10 @@
 MAN8=		cciss_vol_status.8
 PLIST_FILES=	bin/cciss_vol_status
 
+.include <bsd.port.pre.mk>
+
 .if !exists(${SRC_BASE}/sys/dev/ciss/cissio.h)
 IGNORE=		cciss_vol_status requires kernel sources of the ciss driver
 .endif
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--- cciss_vol_status-1.09.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list