ports/169218: [PATCH] print/acroreadwrapper: fix usage of ${SRC_BASE} before it is defined

Jason Helfman jgh at FreeBSD.org
Mon Jun 18 23:40:22 UTC 2012


>Number:         169218
>Category:       ports
>Synopsis:       [PATCH] print/acroreadwrapper: fix usage of ${SRC_BASE} before it is defined
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 18 23:40:21 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Jason Helfman
>Release:        FreeBSD 8.3-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr  9 21:23:18 UTC
>Description:

Original PR filed as ports/165994

SRC_BASE is being used before being defined in several ports. it happened to
work anyways in most cases because the main use of SRC_BASE is for checking if
${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just
checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/.

pet portlint for whitespace

Port maintainer (hrs at FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- acroreadwrapper-0.0.20110920.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/print/acroreadwrapper/Makefile,v
retrieving revision 1.17
diff -u -r1.17 Makefile
--- Makefile	20 Sep 2011 02:17:09 -0000	1.17
+++ Makefile	18 Jun 2012 23:34:17 -0000
@@ -20,7 +20,7 @@
 PLIST_FILES=	bin/acroread8 bin/acroread9 bin/acroread \
 		${KMODDIR}/linux_adobe.ko
 PLIST_DIRS=	${KMODDIR}
-SUB_FILES=	acroread 
+SUB_FILES=	acroread
 SUB_LIST=	ACROBASE8=${ACROBASE8} \
 		ACROBASE9=${ACROBASE9} \
 		ADOBE_LANG=${ADOBE_LANG:U} \
@@ -30,6 +30,9 @@
 		PLUGINDIR=${PLUGINDIR} \
 		KMODDIR=${KMODDIR}
 USE_RC_SUBR=	linux_adobe.sh
+
+.include <bsd.port.pre.mk>
+
 MAKE_ENV=	KMODDIR=${KMODDIR} SYSDIR=${SRC_BASE}/sys DESTDIR=${PREFIX}/
 
 ADOBEBASE=	Adobe
@@ -38,7 +41,6 @@
 PLUGINDIR=	lib/npapi/linux-acroread
 KMODDIR=	libexec/linux_adobe
 
-.include <bsd.port.pre.mk>
 KERNCONF?=	GENERIC
 
 # Use the first component of ${KERNCONF}.
--- acroreadwrapper-0.0.20110920.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list