ports/169214: [PATCH] multimedia/ptx-kmod: fix usage of ${SRC_BASE} before it is defined

Jason Helfman jgh at FreeBSD.org
Mon Jun 18 23:30:18 UTC 2012


>Number:         169214
>Category:       ports
>Synopsis:       [PATCH] multimedia/ptx-kmod: fix usage of ${SRC_BASE} before it is defined
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 18 23:30:17 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Jason Helfman
>Release:        FreeBSD 8.3-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr  9 21:23:18 UTC
>Description:

Original PR filed as ports/165994

SRC_BASE is being used before being defined in several ports. it happened to
work anyways in most cases because the main use of SRC_BASE is for checking if
${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just
checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/.

Pet portlint on LICENSE complaints with other variables in same section.

Port maintainer (hrs at FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- ptx-kmod-0.0.20111212.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/multimedia/ptx-kmod/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile	8 Jan 2012 20:38:47 -0000	1.4
+++ Makefile	18 Jun 2012 23:23:27 -0000
@@ -17,6 +17,7 @@
 COMMENT=	Device driver for PT1/PT2 ISDB-S/T tuner cards
 
 LICENSE=	GPLv3
+
 ONLY_FOR_ARCHS=	amd64 i386
 BUILD_WRKSRC=	${WRKSRC}/dev/ptx
 MAKE_ENV=	KMODDIR=${PREFIX}/${KMODDIR} SYSDIR=${SYSDIR}
@@ -26,10 +27,11 @@
 USE_RC_SUBR=	ptx.sh
 PORTDOCS=	README
 
+.include <bsd.port.pre.mk>
+
 KMODDIR=	libexec/${PORTNAME}
 SYSDIR?=	${SRC_BASE}/sys
 
-.include <bsd.port.pre.mk>
 KERNCONF?=	GENERIC
 
 # Use the first component of ${KERNCONF}.
--- ptx-kmod-0.0.20111212.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list