ports/165503: [patch] fix crash for editors/madedit
Kuan-Chung Chiu
buganini at gmail.com
Mon Feb 27 12:20:08 UTC 2012
>Number: 165503
>Category: ports
>Synopsis: [patch] fix crash for editors/madedit
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Feb 27 12:20:07 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Kuan-Chung Chiu
>Release: 10-CURRENT
>Organization:
N/A
>Environment:
FreeBSD Bohemia.twbbs.org 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r231997: Thu Feb 23 01:35:20 CST 2012 root at Bohemia.twbbs.org:/usr/obj/usr/src/sys/BOHEMIA amd64
>Description:
madedit crash when opening multiple files in an instance.
>How-To-Repeat:
>Fix:
apply
https://github.com/dol/madedit/commit/80b09fb0b0b457cd2a94c46c1185db22f6d302be
Patch attached with submission follows:
diff -ruN madedit.orig/Makefile madedit/Makefile
--- madedit.orig/Makefile 2012-02-27 20:08:23.000000000 +0800
+++ madedit/Makefile 2012-02-27 20:08:32.000000000 +0800
@@ -7,7 +7,7 @@
PORTNAME= madedit
PORTVERSION= 0.2.9
-PORTREVISION= 5
+PORTREVISION= 6
CATEGORIES= editors
MASTER_SITES= SF/${PORTNAME}/MadEdit/MadEdit-${PORTVERSION}
diff -ruN madedit.orig/files/patch-src-MadEdit-MadEdit.cpp madedit/files/patch-src-MadEdit-MadEdit.cpp
--- madedit.orig/files/patch-src-MadEdit-MadEdit.cpp 1970-01-01 08:00:00.000000000 +0800
+++ madedit/files/patch-src-MadEdit-MadEdit.cpp 2012-02-27 20:08:06.000000000 +0800
@@ -0,0 +1,24 @@
+--- src/MadEdit/MadEdit.cpp.orig 2012-02-27 20:06:18.000000000 +0800
++++ src/MadEdit/MadEdit.cpp 2012-02-27 20:07:26.000000000 +0800
+@@ -9739,7 +9739,9 @@
+ {
+ if(m_EditMode!=emHexMode)
+ {
+- memdc.SelectObject(*m_ClientBitmap);
++ if(m_ClientBitmap!=NULL) {
++ memdc.SelectObject(*m_ClientBitmap);
++ }
+ memdc.SetFont(*m_TextFont);
+
+ // calculate rows to paint
+@@ -9917,7 +9919,9 @@
+
+ if(bPaintMark==false)
+ {
+- markdc.SelectObject(*m_MarkBitmap);
++ if(m_MarkBitmap!=NULL) {
++ markdc.SelectObject(*m_MarkBitmap);
++ }
+ markdc.Blit(0,0,m_ClientWidth,m_ClientHeight, &memdc, 0, 0);
+ bPaintMark=true;
+ }
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list