ports/164863: [patch] deskutils/vnc2flv: send ClientInit when security type is "None"

[Phil Phillips]

>Number:         164863
>Category:       ports
>Synopsis:       [patch] deskutils/vnc2flv: send ClientInit when security type is "None"
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 07 18:10:10 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Phil Phillips
>Release:        8.2-RELEASE-p3
>Organization:
Experts Exchange
>Environment:
FreeBSD ip3.dev.redsrci.com 8.2-RELEASE-p3 FreeBSD 8.2-RELEASE-p3 #0: Tue Sep 27 18:45:57 UTC 2011     root at amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
The rfb module in vnc2flv isn't sending a "ClientInit" when there is no authentication. This will break tools (such as rfbproxy) that don't gracefully handle a missing server response.

Here's a small patch for vnc2flv that allows it to properly send the "ClientInit".  I've tested this with a few other VNC servers, including rfbproxy, and it looks like it works.

Patch also submitted upstream: http://groups.google.com/group/vnc2flv-users/browse_thread/thread/63f42b2422104224
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -urN vnc2flv.old/Makefile vnc2flv/Makefile
--- vnc2flv.old/Makefile	2011-12-20 09:10:17.000000000 -0800
+++ vnc2flv/Makefile	2012-02-07 09:52:17.000000000 -0800
@@ -7,6 +7,7 @@
 
 PORTNAME=	vnc2flv
 PORTVERSION=	20100207
+PORTREVISION=	1
 CATEGORIES=	deskutils multimedia www python
 MASTER_SITES=	${MASTER_SITE_CHEESESHOP}
 MASTER_SITE_SUBDIR=	source/v/${PORTNAME}/
diff -urN vnc2flv.old/files/patch-rfb.py vnc2flv/files/patch-rfb.py
--- vnc2flv.old/files/patch-rfb.py	1969-12-31 16:00:00.000000000 -0800
+++ vnc2flv/files/patch-rfb.py	2012-02-07 09:51:57.000000000 -0800
@@ -0,0 +1,11 @@
+--- vnc2flv/rfb.py.orig	2010-01-18 06:19:13.000000000 -0800
++++ vnc2flv/rfb.py	2011-10-18 15:12:54.000000000 -0700
+@@ -152,6 +152,8 @@
+         if server_security == 0:
+             return self.autherr()
+         elif server_security == 1:
++            # send: always shared.
++            self.send('\x01');
+             return self.start()
+         else:
+             return self.crauth()


>Release-Note:
>Audit-Trail:
>Unformatted: