ports/171083: bsd.port.mk: Be more clear in the sanity-config error prompt

Raphael Kubo da Costa rakuco at FreeBSD.org
Sun Aug 26 17:30:02 UTC 2012


>Number:         171083
>Category:       ports
>Synopsis:       bsd.port.mk: Be more clear in the sanity-config error prompt
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 26 17:30:01 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Raphael Kubo da Costa
>Release:        9-STABLE
>Organization:
FreeBSD
>Environment:
FreeBSD gibbon 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #54: Sat Aug  4 23:50:23 BRT 2012     root at gibbon:/usr/obj/usr/src/sys/GIBBON  amd64

>Description:
When one runs `make config' on a port and produces an invalid configuration, the current prompt says "Config is invalid. Re-edit? [Y/N]".

It is not clear whether the default is thus 'Y' or 'N'. The attached patch makes it clear that 'Y' is the default.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: bsd.port.mk
===================================================================
--- bsd.port.mk	(revision 303176)
+++ bsd.port.mk	(working copy)
@@ -6017,7 +6017,7 @@
 .if !target(sanity-config)
 sanity-config: _check-config
 .if !empty(_CHECK_CONFIG_ERROR)
-	@echo -n "Config is invalid. Re-edit? [Y/N] "; \
+	@echo -n "Config is invalid. Re-edit? [Y/n] "; \
 	read answer; \
 	case $$answer in \
 	[Nn]|[Nn][Oo]) \


>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list