ports/170473: [patch] audio/alsa-plugins: disable ARIFF_OSS by default

[Jan Beich]

>Number:         170473
>Category:       ports
>Synopsis:       [patch] audio/alsa-plugins: disable ARIFF_OSS by default
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 08 03:40:01 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Jan Beich
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
>Description:
Disable unmaintaned code. This needs more investigating how it affects
runtime on earlier releases.

https://bugzilla.mozilla.org/show_bug.cgi?id=780531#c8
>How-To-Repeat:
1. checkout https://github.com/kinetiknz/cubeb/
2. edit configure.ac to use asoundlib (only if pulseaudio is also installed)
3. autoreconf -sif && ./configure && gmake
4. ./test/test_tone
Assertion failed: (wrote >= 0 && wrote == got), function cubeb_refill_stream, file src/cubeb_alsa.c, line 307.
Abort

Alternatively, compile Nightly firefox with --disable-floating-point or
MOZ_TREMOR then play a HTML5 video, e.g.

$ firefox youtube.com/watch\?v=<video_id_here>
Assertion failed: (wrote >= 0 && wrote == got), function cubeb_refill_stream, file /a/overlay/gecko/www/firefox-nightly/work/mozilla-central-2637d896de91/media/libcubeb/src/cubeb_alsa.c, line 307.
>Fix:
--- disable.diff begins here ---
Index: audio/alsa-plugins/Makefile
===================================================================
--- audio/alsa-plugins/Makefile	(revision 301674)
+++ audio/alsa-plugins/Makefile	(working copy)
@@ -25,7 +25,6 @@ LDFLAGS+=	-L${LOCALBASE}/lib
 USE_LDCONFIG=	${PREFIX}/lib/alsa-lib
 
 OPTIONS_DEFINE=	ARIFF_OSS JACK FFMPEG PULSEAUDIO SAMPLERATE SPEEX
-OPTIONS_DEFAULT=ARIFF_OSS
 ARIFF_OSS_DESC=	FreeBSD-specific OSS plugin
 
 .include <bsd.port.options.mk>
--- disable.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted: