ports/170404: [PATCH] devel/p5-Devel-GlobalDestruction: Fix invalid plist with perl 5.12 breaking package building

[Bryan Drewery]

>Number:         170404
>Category:       ports
>Synopsis:       [PATCH] devel/p5-Devel-GlobalDestruction: Fix invalid plist with perl 5.12 breaking package building
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 06 06:00:08 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Bryan Drewery
>Release:        FreeBSD 8.3-RELEASE i386
>Organization:
>Environment:

	
>Description:
	The latest update to 0.08 removed the %%OLD_PLIST%%..SITE_PERL/%%ARCH%% plist support for perl 5.12.
	This is apparently still needed.

	7.4 pkg_install:

	=======================<phase: install  >==========================
	===>  Installing for p5-Devel-GlobalDestruction-0.08
	===>   p5-Devel-GlobalDestruction-0.08 depends on package: p5-Sub-Exporter-Progressive>=0.001.002 - found
	===>   p5-Devel-GlobalDestruction-0.08 depends on file: /usr/local/bin/perl5.12.4 - found
	===>   Generating temporary packing list
	===>  Checking if devel/p5-Devel-GlobalDestruction already installed
	Files found in blib/arch: installing files in blib/lib into architecture dependent library tree
	Installing /usr/local/lib/perl5/site_perl/5.12.4/mach/auto/Devel/GlobalDestruction/GlobalDestruction.bs
	Installing /usr/local/lib/perl5/site_perl/5.12.4/mach/auto/Devel/GlobalDestruction/GlobalDestruction.so
	Installing /usr/local/lib/perl5/site_perl/5.12.4/mach/Devel/GlobalDestruction.pm
	Installing /usr/local/lib/perl5/5.12.4/man/man3/Devel::GlobalDestruction.3
	===>   Compressing manual pages for p5-Devel-GlobalDestruction-0.08
	===>   Registering installation for p5-Devel-GlobalDestruction-0.08
	===================================================================
	=======================<phase: package  >==========================
	===>  Building package for p5-Devel-GlobalDestruction-0.08
	tar: lib/perl5/site_perl/5.12.4/Devel/GlobalDestruction.pm: Cannot stat: No such file or directory
	tar: Error exit delayed from previous errors.
	pkg_create: make_dist: tar command failed with code 256
	*** Error code 1

	Stop in /usr/ports/devel/p5-Devel-GlobalDestruction.
	===>  Cleaning for p5-Devel-GlobalDestruction-0.08


	8.2 pkgng:

	=======================<phase: install  >==========================
	===>  Installing for p5-Devel-GlobalDestruction-0.08
	===>   p5-Devel-GlobalDestruction-0.08 depends on package: p5-Sub-Exporter-Progressive>=0.001.002 - found
	===>   p5-Devel-GlobalDestruction-0.08 depends on file: /usr/local/bin/perl5.12.4 - found
	===>   Generating temporary packing list
	===>  Checking if devel/p5-Devel-GlobalDestruction already installed
	Files found in blib/arch: installing files in blib/lib into architecture dependent library tree
	Installing /usr/local/lib/perl5/site_perl/5.12.4/mach/auto/Devel/GlobalDestruction/GlobalDestruction.bs
	Installing /usr/local/lib/perl5/site_perl/5.12.4/mach/auto/Devel/GlobalDestruction/GlobalDestruction.so
	Installing /usr/local/lib/perl5/site_perl/5.12.4/mach/Devel/GlobalDestruction.pm
	Installing /usr/local/lib/perl5/5.12.4/man/man3/Devel::GlobalDestruction.3
	===>   Compressing manual pages for p5-Devel-GlobalDestruction-0.08
	===>   Registering installation for p5-Devel-GlobalDestruction-0.08
	pkg: lstat(/usr/local/lib/perl5/site_perl/5.12.4/Devel/GlobalDestruction.pm): No such file or directory
	pkg: lstat(/usr/local/lib/perl5/site_perl/5.12.4/Devel/): No such file or directory
	Installing p5-Devel-GlobalDestruction-0.08... done
	===================================================================
	=======================<phase: package  >==========================
	===>  Building package for p5-Devel-GlobalDestruction-0.08
	Creating package for p5-Devel-GlobalDestruction-0.08


	redports 7.4 with perl 5.14:

	===>  Installing for p5-Devel-GlobalDestruction-0.08
	===>   p5-Devel-GlobalDestruction-0.08 depends on package: p5-Sub-Exporter-Progressive>=0.001.002 - found
	===>   p5-Devel-GlobalDestruction-0.08 depends on file: /usr/local/bin/perl5.14.2 - found
	===>   Generating temporary packing list
	===>  Checking if devel/p5-Devel-GlobalDestruction already installed
	Manifying blib/man3/Devel::GlobalDestruction.3
	Installing /usr/local/lib/perl5/site_perl/5.14.2/Devel/GlobalDestruction.pm
	Installing /usr/local/lib/perl5/5.14.2/man/man3/Devel::GlobalDestruction.3
	===>   Compressing manual pages for p5-Devel-GlobalDestruction-0.08
	===>   Registering installation for p5-Devel-GlobalDestruction-0.08
	================================================================
	====================<phase 7: make package>====================
	===>  Building package for p5-Devel-GlobalDestruction-0.08
	Deleting p5-Devel-GlobalDestruction-0.08



>How-To-Repeat:
	With PERL_VERSION=5.12.4:
	make install package
>Fix:

	With patch 5.12 successfully builds and 5.14 continues to as well.

--- patch-devel-p5-Devel-GlobalDestruction.plist.txt begins here ---
Only in .: .pkg-plist.swp
diff -ur ../p5-Devel-GlobalDestruction.orig/Makefile ./Makefile
--- ../p5-Devel-GlobalDestruction.orig/Makefile	2012-08-02 05:21:42.000000000 +0200
+++ ./Makefile	2012-08-06 05:59:07.000000000 +0200
@@ -30,4 +30,11 @@
 BUILD_DEPENDS+=	p5-ExtUtils-CBuilder>=0.27:${PORTSDIR}/devel/p5-ExtUtils-CBuilder
 .endif
 
+.if ${PERL_LEVEL} < 501400
+PLIST_SUB+=	OLD_PERL_PLIST="" NEW_PERL_PLIST="@comment "
+.else
+PLIST_SUB+=	OLD_PERL_PLIST="@comment " NEW_PERL_PLIST=""
+.endif
+
+
 .include <bsd.port.post.mk>
diff -ur ../p5-Devel-GlobalDestruction.orig/pkg-plist ./pkg-plist
--- ../p5-Devel-GlobalDestruction.orig/pkg-plist	2012-08-02 05:21:42.000000000 +0200
+++ ./pkg-plist	2012-08-06 06:03:03.000000000 +0200
@@ -1,5 +1,8 @@
-%%SITE_PERL%%/Devel/GlobalDestruction.pm
+%%NEW_PERL_PLIST%%%%SITE_PERL%%/Devel/GlobalDestruction.pm
+%%OLD_PERL_PLIST%%%%SITE_PERL%%/%%PERL_ARCH%%/Devel/GlobalDestruction.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/.packlist
+%%OLD_PERL_PLIST%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/GlobalDestruction.bs
+%%OLD_PERL_PLIST%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/GlobalDestruction.so
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction
 @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel
 @dirrmtry %%SITE_PERL%%/Devel
--- patch-devel-p5-Devel-GlobalDestruction.plist.txt ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: