ports/160595: x11/xset: missing dependencies

[Jilles Tjoelker]

>Number:         160595
>Category:       ports
>Synopsis:       x11/xset: missing dependencies
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 09 19:30:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Jilles Tjoelker
>Release:        FreeBSD 8.2-STABLE i386
>Organization:
The FreeBSD Project
>Environment:
FreeBSD 8.2-STABLE i386
>Description:
x11/xset depends on various libraries without declaring that in the port
Makefile.

In particular, this may cause portmaster to attempt to compile xset
against a too old version of xproto.

The modules xxf86misc and xfontcache are used iff they happen to be
present. This means that the centrally built packages do not have them
but a version built from ports will probably have them.
>How-To-Repeat:
Inspect the port Makefile and the configure.ac file.
>Fix:
Add the missing dependencies to USE_XORG=.

The below patch assumes that xxf86misc and xfontcache are desired.
Alternatively, they could be disabled via configure options.
(xorg-server-1.7.7_2,1 does not appear to support xfontcache.)

The PORTREVISION should be bumped as well.

--- xset-deps.patch begins here ---
--- /usr/ports/x11/xset/Makefile.orig	2011-09-07 23:19:05.000000000 +0200
+++ /usr/ports/x11/xset/Makefile	2011-09-09 19:29:08.000000000 +0200
@@ -13,7 +13,7 @@
 COMMENT=	User preference utility for X
 
 XORG_CAT=	app
-USE_XORG=	xmuu
+USE_XORG=	xmuu xproto x11 xext xxf86misc xfontcache
 
 PLIST_FILES=	bin/xset
 
--- xset-deps.patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: