ports/160490: [PATCH] x11-toolkits/gtk20: drag and drop broken in vnc server

[Marcin Wisnicki]

>Number:         160490
>Category:       ports
>Synopsis:       [PATCH] x11-toolkits/gtk20: drag and drop broken in vnc server
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 05 19:00:04 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Marcin Wisnicki
>Release:        8.2-STABLE
>Organization:
>Environment:
>Description:
https://bugzilla.gnome.org/show_bug.cgi?id=620240

Unfortunately GNOME developers don't care about gtk2.
>How-To-Repeat:
As root:
1. pkg_add -r gnome2 vnc
As user in X:
2. Xvnc :12 -SecurityTypes None &
3. vncviewer :12 &
4. export DISPLAY=:12
5. # start gnome or something (eg. nautilus) and try drag and drop
>Fix:


Patch attached with submission follows:

Commit 0efb24f589a74c4a4e78a1803d6e7205be9c1984 to gtk2 breaks drag and drop on
VNC servers by ignoring X SHAPE extension specification for the benefit of two
broken apps.
Rationale: https://bugzilla.gnome.org/show_bug.cgi?id=620240#c11

--- gdk/x11/gdkwindow-x11.c.orig	2011-02-19 15:31:37.000000000 +0100
+++ gdk/x11/gdkwindow-x11.c	2011-09-05 19:21:10.000000000 +0200
@@ -4663,7 +4663,10 @@
 			     window,
 			     shape_type, &rn, &ord);
 
-  if (xrl == NULL || rn == 0)
+  if (xrl == NULL)
+    return NULL; /* XShape not supported */
+
+  if (rn == 0)
     return gdk_region_new (); /* Empty */
 
   if (ord != YXBanded)


>Release-Note:
>Audit-Trail:
>Unformatted: