ports/160448: ports-mgmt/portlint shall warn about CPPFLAGS being passed to MAKE_ENV

[Gerald Pfeifer]

>Number:         160448
>Category:       ports
>Synopsis:       ports-mgmt/portlint shall warn about CPPFLAGS being passed to MAKE_ENV
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 04 04:00:19 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Gerald Pfeifer
>Release:        
>Organization:
>Environment:
>Description:
	This is the part of ports/155550 that has not been addressed 
	there.

	Recently a change of mine to pass CPPFLAGS to MAKE_ENV has been
	applied to Mk/bsd.port.mk.

	In consequence, individual ports no long should pass this
	explicitly and portlint should warn about
	  MAKE_ENV= CPPFLAGS="${CPPFLAGS}"

	In fact any setting of CPPFLAGS, also along the lines of
	  MAKE_ENV= CPPFLAGS="-Dfoo -D bar"
	should be warned about since, really, CPPFLAGS should be
	set in the port Makefile and the rest should "just happen".
>How-To-Repeat:
	Run portlint -C against revision 1.32 of Makefile in
	finance/quantlib.
>Fix:
>Release-Note:
>Audit-Trail:
>Unformatted: